Some Thinkpad information are misleadble

It looks like all the details from several systems are being conflated here in the output. I checked several Lenovo systems and verified that this is occurring.

For example the x201s and x201 Tablet pages both show the following in their details, even though we only tested a single instance of each.

Processor Intel(R) Core(TM) i3-2310M CPU @ 2.10GHz
Processor Intel(R) Core(TM) i5 CPU M 520 @ 2.40GHz
Processor Intel(R) Core(TM) i5 CPU M 540 @ 2.53GHz
Processor Intel(R) Core(TM) i5-2410M CPU @ 2.30GHz
Processor Intel(R) Core(TM) i7 CPU L 640 @ 2.13GHz
Processor Intel(R) Core(TM) i7 CPU U 620 @ 1.07GHz
Processor Intel(R) Core(TM) i7 CPU X 920 @ 2.00GHz
Processor Intel(R) Core(TM) i7-2620M CPU @ 2.70GHz
Network Intel Corporation 82577LM Gigabit Network Connection
Network Intel Corporation 82579LM Gigabit Network Connection
Network Intel Corporation Centrino Advanced-N 6200
Network Intel Corporation Centrino Advanced-N 6205
Network Intel Corporation Centrino Ultimate-N 6300
Network Realtek Semiconductor Co., Ltd. RTL8111/8168B PCI Express Gigabit Ethernet controller
Video Intel Corporation 2nd Generation Core Processor Family Integrated Graphics Controller
Video Intel Corporation Core Processor Integrated Graphics Controller
Video nVidia Corporation G92 [Quadro FX 3800M]
Video nVidia Corporation GT218 [NVS 3100M]

This is a re-occurrence of a previous bug. What you are seeing is an amalgamation of several Lenovo systems.

That was a fun bug to track down, as it wasn't actually a bug at all but rather an issue with dirty data.

A number of systems had a empty display name (in the database), although this wasn't exposed through the certification interface (which is as it should be).

However for performance we use additional tables which are populated by SQL, which did expose the empty display name. As it grouped systems, they were getting grouped under the empty name (in addition to their correct name), and when we tried to access the machine via it's canonical ID, the system actually served up the grouped record (with the amalgamated hardware).

What I've done is to remove the empty display_name from all affected systems (77 in total), and re-populated the display tables, and things are now displaying as they should.

I'll close this bug accordingly, but raise additional bugs for the issues that caused this situation.

The SQL to address this is:

UPDATE hardware SET display_names = regexp_replace(display_names, E'\n$', '') WHERE display_names ~ E'\n$';