Charm Needed: SchoolTool

Here is a basic charm that installs a schooltool server and exposes it through apache2.

Reviewing this now.

-Juan

Hi Gediminas:

Thank you for the charm submission.

README:
The readme should be a more verbose:
It should have not only a description of the software but, also how the charm works and an example on how to use it.

install/config-changed:
I believe you forgot to open the necessary ports to the app. When I run juju expose schooltool, no ports are opened. You forgot to include open-port 80/TCP ( I assume that it runs on port 80 ).
I would recommend splitting the current install hook into install and config-changed hooks thus leaving only the actual package installation in the install hook and moving the application configuration to config-changed.

start:
Normally, the start hook would ensure that the service is running. In this case, it could look something like:
service schooltool status || service schooltool start
You should also probably do the same for apachew ( service apache2 status || service apache2 start )

stop:
It would be better ( IMHO ) to use: service schooltool stop instead of the full path of the service

website-relation-joined:
This hook is missing . In this hook we would do something like:
relation-set host=`unit-get public-address` port=80 # This is just an example

website-relation-changed:
This hook is empty. Given the application, I don't much see the need for this hook so you can take it out.

At this point, I am marking this Incomplete as there are issues that need addressing. I would be glad to review the charm again once you have addressed the issues detailed above.

There is a whole community of people that can help you if I am not available. We are usually in #juju on freenode.

Thanks,

Juan

[Expired for Juju Charms Collection because there has been no activity for 60 days.]