mumble-server charm
Bug #992962 reported by
Kees Cook
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Juju Charms Collection |
Fix Released
|
Medium
|
Kees Cook |
Bug Description
This implements a juju charm for installing and configuring a mumble server for VoIP collaboration.
Related branches
To post a comment you must log in.
HI Kees! Thanks for another charm. Review here:
=== Blocking Issues ===
* The default password of 'unset' is not checked for in config-changed. This hook is always called once right after the charm gets to a 'started' state, so if the user forgets to set the password, they will have a mumble server with the password of 'unset'. We've decided to disallow charms which set default passwords. I'd recommend checking for it, and just exitting config-changed quietly if it is still 'unset'.
* The interface name of 'settings' seems *really* generic. The idea is to keep people from accidentally relating incompatible services together. I'm not sure settings will do enough to prevent that, and it may produce some confusion.
Can it just be 'interface: mumble' instead and drop the protocol bit?
* hostname -f is not reliable enough, as some providers will set things up in a way where hostname -f returns a bogus address. use `unit-get private-address` instead. The private address is always the one that will (should!) be accessible from other nodes in the same environment.
==== Next Steps ====
If you can address those, we can promulgate this into the store. It should be a nice addition. :)