ceilometer-next needs lint cleanup

Bug #1375350 reported by Ryan Beisner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ceilometer (Juju Charms Collection)
Fix Released
Medium
Liam Young

Bug Description

lp:~openstack-charmers/charms/trusty/ceilometer/next needs some tidying of lint:

00:00:28.747 Creating new checkout of lp:~openstack-charmers/charms/trusty/ceilometer/next @ /var/lib/jenkins/checkout/ceilometer.
00:00:37.682 Gathering info about branch...
00:00:37.684 `Makefile' -> `/var/lib/jenkins/workspace/charm_lint_check/Makefile.153'
00:00:49.107 52
00:00:57.996 Lightweight checkout (format: 2a)
00:00:57.996 Location:
00:00:57.996 light checkout root: .
00:00:57.996 checkout of branch: bzr+ssh://bazaar.launchpad.net/~openstack-charmers/charms/trusty/ceilometer/next/
00:00:57.996
00:00:57.996 Related branches:
00:00:57.996 parent branch: bzr+ssh://bazaar.launchpad.net/+branch/charms/trusty/ceilometer/
00:00:57.996 stacked on: /+branch-id/735282
00:00:58.244 Checking lint...
00:00:58.244 + pwd
00:00:58.244 /var/lib/jenkins/checkout/ceilometer
00:00:58.244 + tee /var/lib/jenkins/workspace/charm_lint_check/make-lint.153
00:00:58.246 + make lint
00:00:58.497 hooks/ceilometer_hooks.py:9:1: F401 'unit_get' imported but unused
00:00:58.497 hooks/ceilometer_hooks.py:37:1: F401 'get_address_in_network' imported but unused
00:00:58.497 hooks/ceilometer_hooks.py:99:1: E302 expected 2 blank lines, found 1
00:00:58.497 hooks/ceilometer_hooks.py:106:33: W291 trailing whitespace
00:00:58.497 hooks/ceilometer_hooks.py:118:6: W291 trailing whitespace
00:00:58.497 hooks/ceilometer_hooks.py:122:80: E501 line too long (87 > 79 characters)
00:00:58.497 hooks/ceilometer_utils.py:54:1: E265 block comment should start with '# '
00:00:58.497 hooks/ceilometer_utils.py:55:1: E265 block comment should start with '# '
00:00:58.497 hooks/ceilometer_utils.py:59:1: E265 block comment should start with '# '
00:00:58.508 make: *** [lint] Error 1
00:00:58.508 + [[ 2 != \0 ]]
00:00:58.508 + echo 'Lint check failed.'
00:00:58.508 Lint check failed.
00:00:58.508 + touch /var/lib/jenkins/workspace/charm_lint_check/make-lint.failed
00:00:58.509 + exit 1
00:00:58.516 Build step 'Execute shell' marked build as failure
00:00:58.538 Archiving artifacts
00:00:58.570 Sending e-mails to: <email address hidden>
00:00:58.794 Finished: FAILURE

Tags: uosci

Related branches

Ryan Beisner (1chb1n)
tags: added: osci
Ryan Beisner (1chb1n)
tags: added: uosci
removed: osci
Liam Young (gnuoy)
Changed in ceilometer (Juju Charms Collection):
importance: Undecided → Medium
assignee: nobody → Liam Young (gnuoy)
Liam Young (gnuoy)
Changed in ceilometer (Juju Charms Collection):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.