please trim whitespace around registration-key value
Bug #1511175 reported by
Paul Collins
This bug affects 7 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| landscape-client-charm |
Fix Released
|
Low
|
Chad Smith | ||
| landscape-client (Juju Charms Collection) |
Fix Released
|
Low
|
Chad Smith | ||
Bug Description
Many of our deployments of landscape-client are done with the help of juju-deployer. Rather than risk including our registration key in revision-controlled files, we store it in a separate file and refer to it from the juju-deployer files with "include-file://".
The registration-key file often ends in a newline, which can be difficult to avoid with certain tools and text editors. The charm then passes the newline straight through when creating client.conf, which causes registration to fail.
Please consider updating the landscape-client charm to remove surrounding whitespace from registration-key.
Related branches
lp://qastaging/~chad.smith/charms/trusty/landscape-client/landscape-client-scrub-whitespace
- Bogdana Vereha (community): Approve
- Adam Collard (community): Approve
-
Diff: 44 lines (+22/-1)2 files modifiedhooks/hooks.py (+1/-1)
hooks/test_hooks.py (+21/-0)
| tags: | added: kanban |
| tags: | removed: kanban |
Revision history for this message
| Junien Fridrick (axino) wrote | #1 |
Revision history for this message
| David Britton (dpb) wrote | #2 |
| Changed in landscape-client (Juju Charms Collection): | |
| status: | New → Confirmed |
| Changed in landscape-client-charm: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
| Changed in landscape-client (Juju Charms Collection): | |
| importance: | Undecided → Low |
Revision history for this message
| Tom Haddon (mthaddon) wrote | #3 |
| tags: | added: is |
| tags: | added: squad-bug |
| tags: | added: kanban |
| tags: | removed: kanban |
| Changed in landscape-client (Juju Charms Collection): | |
| assignee: | nobody → Chad Smith (chad.smith) |
| Changed in landscape-client (Juju Charms Collection): | |
| status: | Confirmed → In Progress |
| Changed in landscape-client-charm: | |
| status: | Confirmed → Won't Fix |
| status: | Won't Fix → In Progress |
| assignee: | nobody → Chad Smith (chad.smith) |
Revision history for this message
| Chad Smith (chad.smith) wrote | #4 |
| Changed in landscape-client-charm: | |
| status: | In Progress → Fix Committed |
| Changed in landscape-client (Juju Charms Collection): | |
| status: | In Progress → Fix Committed |
| Changed in landscape-client (Juju Charms Collection): | |
| status: | Fix Committed → Fix Released |
| Changed in landscape-client-charm: | |
| status: | Fix Committed → Fix Released |
| Changed in landscape-client-charm: | |
| status: | Fix Released → Triaged |
| Changed in landscape-client-charm: | |
| status: | Triaged → Fix Released |
To post a comment you must log in.
Hi,
I got affected by this today. Any ETA for a fix ?