charmhelpers.contrib.charmsupport.nrpe add_init_service doesn't support systemd
Bug #1578922 reported by
Brad Marshall
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Charm Helpers |
New
|
Undecided
|
Unassigned | ||
| nrpe (Juju Charms Collection) |
Fix Committed
|
Undecided
|
Unassigned | ||
| nrpe-external-master (Juju Charms Collection) |
Fix Committed
|
Undecided
|
Unassigned | ||
Bug Description
As of bzr revno 570 charmhelpers.
When used on a xenial system, it finds the upstart conf file and tries to use a nrpe check with upstart, which fails and the check fails.
It appears that function needs another path check for the systemd service file, ahead of the upstart one.
Once this is fixed a simple refresh of the charmhelpers in any affected charms should clear up the error.
Please let me know if you need any more information.
Related branches
lp://qastaging/~brad-marshall/charm-helpers/add-systemd-nagios-check
- Stuart Bishop (community): Needs Fixing
-
Diff: 36 lines (+19/-0) (has conflicts)1 file modifiedcharmhelpers/contrib/charmsupport/nrpe.py (+19/-0)
lp://qastaging/~brad-marshall/charms/trusty/nrpe/add-systemd-nagios-check
- Stuart Bishop (community): Approve
- Review Queue (community): Needs Fixing (automated testing)
-
Diff: 43 lines (+39/-0)1 file modifiedfiles/plugins/check_systemd.py (+39/-0)
lp://qastaging/~brad-marshall/charms/precise/nrpe-external-master/add-systemd-nagios-check
- Stuart Bishop (community): Approve
- Review Queue (community): Approve (automated testing)
-
Diff: 43 lines (+39/-0)1 file modifiedfiles/check_systemd.py (+39/-0)
Revision history for this message
| Brad Marshall (brad-marshall) wrote | #1 |
| Changed in nrpe (Juju Charms Collection): | |
| status: | New → Fix Released |
| Changed in nrpe-external-master (Juju Charms Collection): | |
| status: | New → Fix Released |
| status: | Fix Released → Fix Committed |
| Changed in nrpe (Juju Charms Collection): | |
| status: | Fix Released → Fix Committed |
To post a comment you must log in.
I've put a proposed fix up at https:/