Juju Charms Collection
rabbitmq-server package

KeyError: 'nagios_servicegroups'

Bug #1404329 reported by Ryan Beisner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
rabbitmq-server (Juju Charms Collection)
Fix Released
Undecided
Unassigned

Bug Description

All OpenStack deployment test targets from stable and next charms are failing on rmq rev 75 with:

## deployer:
2014-12-19 16:49:50 [DEBUG] deployer.env: Delta unit: rabbitmq-server/0 change:installed
2014-12-19 16:49:55 [DEBUG] deployer.env: Delta unit: rabbitmq-server/0 change:error
2014-12-19 16:49:55 [ERROR] deployer.env: The following units had errors:
   unit: rabbitmq-server/0: machine: 18 agent-state: error details: hook failed: "config-changed"

## rmq unit:
2014-12-19 16:49:54 DEBUG worker.uniter.jujuc server.go:103 hook context id "rabbitmq-server/0:config-changed:1993459417124476147"; dir "/var/lib/juju/agents/unit-rabbitmq-server-0/charm"
2014-12-19 16:49:54 INFO config-changed Traceback (most recent call last):
2014-12-19 16:49:54 INFO config-changed File "/var/lib/juju/agents/unit-rabbitmq-server-0/charm/hooks/config-changed", line 655, in <module>
2014-12-19 16:49:54 INFO config-changed hooks.execute(sys.argv)
2014-12-19 16:49:54 INFO config-changed File "/var/lib/juju/agents/unit-rabbitmq-server-0/charm/hooks/charmhelpers/core/hookenv.py", line 508, in execute
2014-12-19 16:49:54 INFO config-changed self._hooks[hook_name]()
2014-12-19 16:49:54 INFO config-changed File "/var/lib/juju/agents/unit-rabbitmq-server-0/charm/hooks/config-changed", line 644, in config_changed
2014-12-19 16:49:54 INFO config-changed restart_rabbit_update_nrpe()
2014-12-19 16:49:54 INFO config-changed File "/var/lib/juju/agents/unit-rabbitmq-server-0/charm/hooks/config-changed", line 594, in restart_rabbit_update_nrpe
2014-12-19 16:49:54 INFO config-changed update_nrpe_checks()
2014-12-19 16:49:54 INFO config-changed File "/var/lib/juju/agents/unit-rabbitmq-server-0/charm/hooks/config-changed", line 459, in update_nrpe_checks
2014-12-19 16:49:54 INFO config-changed nrpe_compat = NRPE(hostname=hostname)
2014-12-19 16:49:54 INFO config-changed File "/var/lib/juju/agents/unit-rabbitmq-server-0/charm/hooks/charmhelpers/contrib/charmsupport/nrpe.py", line 197, in __init__
2014-12-19 16:49:54 INFO config-changed self.nagios_servicegroups = self.config['nagios_servicegroups']
2014-12-19 16:49:54 INFO config-changed File "/var/lib/juju/agents/unit-rabbitmq-server-0/charm/hooks/charmhelpers/core/hookenv.py", line 215, in __getitem__
2014-12-19 16:49:54 INFO config-changed return (self._prev_dict or {})[key]
2014-12-19 16:49:54 INFO config-changed KeyError: 'nagios_servicegroups'
2014-12-19 16:49:54 ERROR juju.worker.uniter uniter.go:486 hook failed: exit status 1

## add'l info
rabbitmq-server: 75
   checkout of branch: bzr+ssh://bazaar.launchpad.net/+branch/charms/trusty/rabbitmq-server/

full logs @:
http://10.245.162.77:8080/view/Dashboard%3A%20Deploy/job/deploy_with_deployer/702/artifact/logs/

Related branches

lp://qastaging/~heut2008/charms/trusty/rabbitmq-server/sync-charmhelpers
Charles Butler (community): Needs Fixing
Review Queue (community): Needs Fixing (automated testing)
Diff: 927 lines (+248/-171)
5 files modified
hooks/charmhelpers/contrib/charmsupport/nrpe.py (+18/-5)
hooks/charmhelpers/contrib/network/ip.py (+50/-46)
hooks/charmhelpers/contrib/openstack/context.py (+89/-27)
hooks/charmhelpers/contrib/openstack/neutron.py (+16/-1)
hooks/charmhelpers/contrib/storage/linux/ceph.py (+75/-92)
lp://qastaging/charms/trusty/rabbitmq-server (Merged)
Revision history for this message
Ryan Beisner (1chb1n) wrote :

FYI, unit test target seems to be ineffective atm:

ubuntu@beisner-bastion:~/bzr/sync-charmhelpers⟫ make test
Starting tests...
CHARM_DIR=/home/ubuntu/bzr/sync-charmhelpers PYTHONPATH=/home/ubuntu/bzr/sync-charmhelpers/hooks nosetests /home/ubuntu/bzr/sync-charmhelpers/hooks
.
----------------------------------------------------------------------
Ran 1 test in 0.164s

OK

http://paste.ubuntu.com/9571590/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

FYI - deploys are clean after rolling back rmq to rev 74.

Revision history for this message
James Page (james-page) wrote :

The stable and next charms have both had releases since this issue, so I think this should be resolved. The config get call is now guarded to ensure that nagios_servicegroups exists in the config object first.

Marking Fixed released

Changed in rabbitmq-server (Juju Charms Collection):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.