Cinder

FLAGS for volume driver tests should not be set in fake_flags file

Bug #1038183 reported by John Griffith
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
High
John Griffith
Cinder 2012.2 "folsom"

Bug Description

Setting the xiv proxy flag in fake_flags breaks the ability to run individual tests. Also these specific test instance flags should be set in the corresponding tests setup method.

John Griffith (john-griffith)
Changed in cinder:
assignee: nobody → John Griffith (john-griffith)
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/11567

Changed in cinder:
status: New → In Progress
Revision history for this message
John Griffith (john-griffith) wrote :

Actually adding the setting in fake_flags is fine... but not adding the driver in the declare causes issues when running individual tests. Add the declare and should be good.

Thanks to Vish for pointing this out.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/11567
Committed: http://github.com/openstack/cinder/commit/bace7fb1b6596c44c500468f689b9b1ef4ad5222
Submitter: Jenkins
Branch: master

commit bace7fb1b6596c44c500468f689b9b1ef4ad5222
Author: John Griffith <email address hidden>
Date: Fri Aug 17 11:27:21 2012 -0600

    Add declare for xiv driver in fake_flags

      fixes bug 1038183

    Change-Id: I324a8e4df61782c903146cc8e0bb1d1bbae46c2f

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → folsom-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.