Cinder

lack the quota commit of reservation

Bug #1048158 reported by Rongze Zhu
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Rongze Zhu
Cinder 2012.2 "folsom"

Bug Description

nova.volume.api.API.create_volume call "reservations = QUOTAS.reserve(context, volumes=1, gigabytes=size)", then nova.volume.manager.VolumeManager.create_volume call "QUOTAS.commit(context, reservations)".

But cinder.volume.manager.VolumeManager.create_volume don't call QUOTAS.commit, so it need to do the same work in cinder.

Also missing working quota code in volume.api.API.delete_volume and volume.manager.VolumeManager.delete_volume

See original description
Rongze Zhu (zrzhit)
Changed in cinder:
assignee: nobody → Rongze Zhu (zrzhit)
clayg (clay-gerrard)
summary: - lack the commit of reservation
+ lack the quota commit of reservation
Changed in cinder:
status: New → Confirmed
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/12852

Changed in cinder:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/12852
Committed: http://github.com/openstack/cinder/commit/a955730b569be6f1132cbd254d8f21828c54d2f2
Submitter: Jenkins
Branch: master

commit a955730b569be6f1132cbd254d8f21828c54d2f2
Author: Rongze Zhu <email address hidden>
Date: Wed Sep 12 07:10:53 2012 +0000

    Add volume quota in volume/api.py and olume/manager.py

    Fixes bug #1048158

    volume.api.API.create() call QUOTAS.reserve(), then
    volume.manager.VolumeManager.create_volume call QUOTAS.commit().
    volume.manager.VolumeManager.delete_volume call QUOTAS.reserve() and
    QUOTAS.commit().

    It also fixes bug #1049459.

    Change-Id: I764aeec83cce93595fbe9aa00205a7d8c9e13c35

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → folsom-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: folsom-rc1 → 2012.2
Revision history for this message
Stephen (stephen-kahmann) wrote :

How do I pull this fix into my installation on ubuntu 12.10?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.