Cinder

Create a separate [quota] section for quota parameters

Bug #1934025 reported by Takashi Kajinami
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
In Progress
Wishlist
Takashi Kajinami
OpenStack Shared File Systems Service (Manila)
Fix Released
Medium
Takashi Kajinami
OpenStack Shared File Systems Service (Manila) xena-3

Bug Description

Currently all quota parameters are registered to the [DEFAULT] section but this makes the default section undesirably huge.
Also, it is difficult to understand some parameters like max_age or until_refresh are for the quota feature by these names.

Now nova has all quota parameters in [quota] section.
We can follow that and can migrate all quota parameters to new [quota] section so that users and operators can easily understand these options are for quota features.

OpenStack Infra (hudson-openstack)
Changed in cinder:
status: New → In Progress
Takashi Kajinami (kajinamit)
Changed in cinder:
assignee: nobody → Takashi Kajinami (kajinamit)
Vida Haririan (vhariria)
tags: added: quotas
Vida Haririan (vhariria)
Changed in manila:
importance: Undecided → Medium
milestone: none → xena-3
status: New → In Progress
Revision history for this message
Goutham Pacha Ravi (gouthamr) wrote :

Fix proposed to openstack/manila branch: master
    https://review.opendev.org/c/openstack/manila/+/772196

Changed in manila:
assignee: nobody → Takashi Kajinami (kajinamit)
Revision history for this message
Vida Haririan (vhariria) wrote :

Additional comments https://meetings.opendev.org/meetings/manila/2021/manila.2021-07-01-15.00.log.html

Fix proposed - #link https://review.opendev.org/c/openstack/manila/+/772196

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/799130

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.opendev.org/c/openstack/manila/+/799130
Committed: https://opendev.org/openstack/manila/commit/76cfc9405ea8b318e8b1c589fa245f86a5827b71
Submitter: "Zuul (22348)"
Branch: master

commit 76cfc9405ea8b318e8b1c589fa245f86a5827b71
Author: Takashi Kajinami <email address hidden>
Date: Fri Jul 2 10:44:14 2021 +0900

    Migrate all quota parameters to [quota] section.

    Currently we register all parameters about the quota feature to
    [DEFAULT] section. However it is difficult for operators to identity
    that some of these parameters like reservation_expire are used in the
    quota feature, based of names and descriptions of the parameters.

    This change migrates all quota options to the new [quota] section,
    so that operators can easily understand which parameters are used
    in the quota feature.

    Closes-Bug: #1934025
    Change-Id: I83b5750da7083718d39efb56262a49dae0a05f48

Changed in manila:
status: In Progress → Fix Released
Sofia Enriquez (lsofia-enriquez)
Changed in cinder:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 13.0.0.0rc1

This issue was fixed in the openstack/manila 13.0.0.0rc1 release candidate.

Sofia Enriquez (lsofia-enriquez)
Changed in cinder:
importance: Medium → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to manila (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/851594

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to manila (master)

Reviewed: https://review.opendev.org/c/openstack/manila/+/851594
Committed: https://opendev.org/openstack/manila/commit/68a5e93ff9ba00b58804ad8b9d12d48cdc25802f
Submitter: "Zuul (22348)"
Branch: master

commit 68a5e93ff9ba00b58804ad8b9d12d48cdc25802f
Author: Takashi Kajinami <email address hidden>
Date: Sat Jul 30 01:28:15 2022 +0900

    Fix reference to deprecated quota_driver option

    The commit 76cfc9405ea8b318e8b1c589fa245f86a5827b71 moved all quota_*
    options to the separate quota section but the commit missed one usage
    of the old quota_driver option, and the remaining usage causes
    the following warning warning to appear repeatedly.

    Config option None.quota_driver is deprecated.
    Use option quota.driver instead.

    This replaces the remaining usage to get rid of that warning.

    Related-Bug: #1934025
    Closes-Bug: #1983125
    Change-Id: Ie49dbe4633a34d1832f0dedb658d83ec74d351df

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to manila (stable/yoga)

Related fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/manila/+/852094

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to manila (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/manila/+/852094
Committed: https://opendev.org/openstack/manila/commit/e4c8c723340dcb76ad508295cd22554d0cbe5f38
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit e4c8c723340dcb76ad508295cd22554d0cbe5f38
Author: Takashi Kajinami <email address hidden>
Date: Sat Jul 30 01:28:15 2022 +0900

    Fix reference to deprecated quota_driver option

    The commit 76cfc9405ea8b318e8b1c589fa245f86a5827b71 moved all quota_*
    options to the separate quota section but the commit missed one usage
    of the old quota_driver option, and the remaining usage causes
    the following warning warning to appear repeatedly.

    Config option None.quota_driver is deprecated.
    Use option quota.driver instead.

    This replaces the remaining usage to get rid of that warning.

    Related-Bug: #1934025
    Closes-Bug: #1983125
    Change-Id: Ie49dbe4633a34d1832f0dedb658d83ec74d351df
    (cherry picked from commit 68a5e93ff9ba00b58804ad8b9d12d48cdc25802f)

tags: added: in-stable-yoga
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.