Cinder

[DEFAULT] use_forwarded_for is duplicate of the HTTPProxyToWSGI middleware

Bug #1967686 reported by Takashi Kajinami
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
In Progress
Low
Takashi Kajinami
OpenStack Compute (nova)
Fix Released
Undecided
Takashi Kajinami
OpenStack Shared File Systems Service (Manila)
Fix Released
Low
Takashi Kajinami
OpenStack Shared File Systems Service (Manila) zed-1

Bug Description

The [DEFAULT] use_forwarded_for parameter enables detection of remote address by the X-Forwarded-For request header.
However this functionality is duplicate of the HTTPProxyToWSGI middleware in the oslo.middleware library.

Now the HTTPProxyToWSGI middleware is enabled in api pipeline by default, and also is globally used by multiple components, the own use_forwarded_for parameter can be removed.

See original description
Takashi Kajinami (kajinamit)
Changed in cinder:
assignee: nobody → Takashi Kajinami (kajinamit)
Changed in nova:
assignee: nobody → Takashi Kajinami (kajinamit)
Changed in manila:
assignee: nobody → Takashi Kajinami (kajinamit)
description: updated
OpenStack Infra (hudson-openstack)
Changed in nova:
status: New → In Progress
Changed in cinder:
status: New → In Progress
Changed in manila:
status: New → In Progress
Takashi Kajinami (kajinamit)
Changed in ec2-api:
assignee: nobody → Takashi Kajinami (kajinamit)
no longer affects: ec2-api
Sofia Enriquez (lsofia-enriquez)
Changed in cinder:
importance: Undecided → Low
Sofia Enriquez (lsofia-enriquez)
tags: added: need-integration-test
tags: removed: need-integration-test
Vida Haririan (vhariria)
Changed in cinder:
status: In Progress → Confirmed
status: Confirmed → In Progress
Changed in manila:
status: In Progress → Confirmed
importance: Undecided → Low
milestone: none → zed-1
status: Confirmed → In Progress
Revision history for this message
Goutham Pacha Ravi (gouthamr) wrote :

Change proposed to branch: master (manila)
    https://review.opendev.org/c/openstack/manila/+/836251

Revision history for this message
Vida Haririan (vhariria) wrote :

Fix was proposed #link https://review.opendev.org/c/openstack/manila/+/836251 (Deprecate [DEFAULT] use_forwarded_for)

Revision history for this message
Vida Haririan (vhariria) wrote :

See additional discussions at https://meetings.opendev.org/meetings/manila/2022/manila.2022-04-21-15.00.log.html

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.opendev.org/c/openstack/manila/+/836251
Committed: https://opendev.org/openstack/manila/commit/b24fc87a1d26ce3447c5fc914f55fb199a2b7702
Submitter: "Zuul (22348)"
Branch: master

commit b24fc87a1d26ce3447c5fc914f55fb199a2b7702
Author: Takashi Kajinami <email address hidden>
Date: Mon Apr 4 00:27:42 2022 +0900

    Deprecate [DEFAULT] use_forwarded_for

    ... because functionality of this parameter is effectively duplicate of
    the HTTPProxyToWSGI middleware in oslo.middleware library.

    Closes-Bug: #1967686
    Change-Id: I4db615093b739c7ff582f348a6fb6eabb8068257

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.opendev.org/c/openstack/nova/+/836253
Committed: https://opendev.org/openstack/nova/commit/cf906cdcc25c112956f56f9fb9f62b2cfdeacc65
Submitter: "Zuul (22348)"
Branch: master

commit cf906cdcc25c112956f56f9fb9f62b2cfdeacc65
Author: Takashi Kajinami <email address hidden>
Date: Mon Apr 4 00:43:18 2022 +0900

    Deprecate [api] use_forwarded_for

    ... because functionality of this parameter is effectively duplicate of
    the HTTPProxyToWSGI middleware in oslo.middleware library.

    Closes-Bug: #1967686
    Change-Id: Ifebcfb6b5c1594c075bb9c152a06aa7af7c61bc8

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 26.0.0.0rc1

This issue was fixed in the openstack/nova 26.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 15.0.0.0rc1

This issue was fixed in the openstack/manila 15.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/nova/+/903339

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/cinder/+/903340

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by "Takashi Kajinami <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/cinder/+/903340
Reason: this is duplicate of https://review.opendev.org/c/openstack/cinder/+/836252

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to nova (master)

Reviewed: https://review.opendev.org/c/openstack/nova/+/903339
Committed: https://opendev.org/openstack/nova/commit/a5f68d355c97baddf2baf46d9630175d65c36968
Submitter: "Zuul (22348)"
Branch: master

commit a5f68d355c97baddf2baf46d9630175d65c36968
Author: Takashi Kajinami <email address hidden>
Date: Mon Dec 11 21:50:41 2023 +0900

    Remove deprecated [api] use_forwarded_for

    This option was deprecated in favor of the HTTPProxyToWSGI middleware
    in 26.0.0 release[1].

    [1] cf906cdcc25c112956f56f9fb9f62b2cfdeacc65

    Related-Bug: #1967686
    Change-Id: Iad8880127531dc2788d646f8a05b5c17fd9d0969

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.