Cinder

quota tests fail with AttributeError

Series liberty
Bug #1600529

Bug #1600529 reported by Tom Barron on 2016-07-09

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	Cinder	Fix Released	Critical	Jamie Lennox
	Liberty	Fix Released	Critical	Eric Harney

Bug Description

Change sets in gate that have nothing to do with quotas, e.g.

https://review.openstack.org/#/c/337500/

show 77 tests failing, all related to quota tests:

http://logs.openstack.org/00/337500/1/gate/gate-cinder-python27-db/5425911/console.html#_2016-07-09_20_08_07_816650

Attribute error is coming from keystone_middleware.auth_token, which no longer has a direct CONF attribute.

This issue is reproducible locally by cloning a fresh cinder workspace and running 'tox -epy27'.

Tags:

Tom Barron (tpb) on 2016-07-09

Changed in cinder:
assignee:	nobody → Tom Barron (tpb)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-07-09: Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/340073

Changed in cinder:
status:	New → In Progress

Revision history for this message

Tom Barron (tpb) wrote on 2016-07-10:

Related bug (for liberty, where we'll likely fix with upper-constraints): https://bugs.launchpad.net/cinder/+bug/1599855

Avishay Traeger (avishay-il) on 2016-07-10

Changed in cinder:
importance:	Undecided → Critical

OpenStack Infra (hudson-openstack) on 2016-07-11

Changed in cinder:
assignee:	Tom Barron (tpb) → Jamie Lennox (jamielennox)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-07-11: Change abandoned on cinder (master)

Change abandoned by Tom Barron (<email address hidden>) on branch: master
Review: https://review.openstack.org/340073
Reason: Jamie is right.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-07-11: Fix merged to cinder (master)

Reviewed: https://review.openstack.org/340196
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=0bd4a6c286c9d867d04f77b17abf4862f3095742
Submitter: Jenkins
Branch: master

commit 0bd4a6c286c9d867d04f77b17abf4862f3095742
Author: Jamie Lennox <email address hidden>
Date: Mon Jul 11 09:24:26 2016 +1000

Don't apply config fixture to auth_token.CONF

    auth_token.CONF is simply the global oslo.config conf object linked into
    the auth_token module. It is not intended for public use and has
    recently been moved.

We can mock exactly the same entries without having to reach into
auth_token middleware and should do that instead.

Closes-Bug: #1600529
Change-Id: I5e8a481f37a7b409e491ce893a0e898d5085cc75

Changed in cinder:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-07-11: Fix proposed to cinder (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/340521

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-07-11: Fix proposed to cinder (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/340532

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-07-12: Fix merged to cinder (stable/mitaka)

Reviewed: https://review.openstack.org/340521
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=cfa30560206842cc8b347560b390faf3a5839499
Submitter: Jenkins
Branch: stable/mitaka

commit cfa30560206842cc8b347560b390faf3a5839499
Author: Jamie Lennox <email address hidden>
Date: Mon Jul 11 09:24:26 2016 +1000

Don't apply config fixture to auth_token.CONF

    auth_token.CONF is simply the global oslo.config conf object linked into
    the auth_token module. It is not intended for public use and has
    recently been moved.

We can mock exactly the same entries without having to reach into
auth_token middleware and should do that instead.

    Closes-Bug: #1600529
    Change-Id: I5e8a481f37a7b409e491ce893a0e898d5085cc75
    (cherry picked from commit 0bd4a6c286c9d867d04f77b17abf4862f3095742)
    Conflicts:
     cinder/tests/unit/api/contrib/test_quotas.py

tags:

added: in-stable-mitaka

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2016-07-14: Fix included in openstack/cinder 9.0.0.0b2

This issue was fixed in the openstack/cinder 9.0.0.0b2 development milestone.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-07-15: Fix merged to cinder (stable/liberty)

Reviewed: https://review.openstack.org/340532
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=399d4c797bdd0b4930a01b435ea128cfad2fb388
Submitter: Jenkins
Branch: stable/liberty

commit 399d4c797bdd0b4930a01b435ea128cfad2fb388
Author: Jamie Lennox <email address hidden>
Date: Wed Mar 2 00:07:14 2016 +0000

Don't apply config fixture to auth_token.CONF

    auth_token.CONF is simply the global oslo.config conf object linked into
    the auth_token module. It is not intended for public use and has
    recently been moved.

We can mock exactly the same entries without having to reach into
auth_token middleware and should do that instead.

    * Also contains this change:
      Update quota_utils with import for keystone_auth
      Author: Ryan McNair <email address hidden>
      Change-Id: I3ebb9979d37f62db161e2929fe2cff5a8ba2bf96
      (cherry picked from commit 4d66d2e833b86156e49ee34da49f7d6040945af1)
      Conflicts:
            cinder/quota_utils.py