CLI Companion

Commands run in wrong tab

Bug #615481 reported by Duane Hinnen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
CLI Companion
Fix Released
High
CLI Companion Development Team
CLI Companion 1.0rc "Arkoma"

Bug Description

open the new clicompanion 0.0.8 trunk version.

TO REPRODUCE:
Click File > New Tab.
Tab 2 is created over Tab1
Click back to Tab1.
Select a command and click Apply to run a command.
The command runs in Tab2 even though you have switched back to Tab1.

What should happen:
Click File > New Tab.
Tab 2 is created over Tab1.
Click back to Tab1.
Select a command and click Apply to run a command.
The command is run in Tab1 the tab you have in front.

The application needs to keep better track of which Tab you have 'in focus'

Related branches

lp://qastaging/clicompanion
David Caro (community): Needs Information
Duane Hinnen: Needs Resubmitting
Diff: 5659 lines (+5448/-23) (has conflicts)
25 files modified
.bzrignore (+8/-0)
.clicompanion (+48/-23)
MANIFEST (+23/-0)
clicompanion (+66/-0)
clicompanion.1 (+61/-0)
clicompanionlib/__init__.py (+23/-0)
clicompanionlib/config.py (+353/-0)
clicompanionlib/helpers.py (+186/-0)
clicompanionlib/menus_buttons.py (+253/-0)
clicompanionlib/plugins.py (+249/-0)
clicompanionlib/preferences.py (+708/-0)
clicompanionlib/tabs.py (+598/-0)
clicompanionlib/utils.py (+269/-0)
clicompanionlib/view.py (+575/-0)
data/clicompanion.desktop (+7/-0)
data/clicompanion2.config.debian (+150/-0)
data/clicompanion2.config.ubuntu (+150/-0)
locale/clicompanion.pot (+155/-0)
plugins/CommandLineFU.py (+282/-0)
plugins/LaunchpadURL.py (+62/-0)
plugins/LocalCommandList.py (+808/-0)
plugins/StandardURLs.py (+91/-0)
plugins/__init__.py (+23/-0)
plugins/clfu.py (+243/-0)
setup.py (+57/-0)
Revision history for this message
Duane Hinnen (duanedesign) wrote :

I assigned this to be fixed before we do the next public release. I think the other developers on the project will agree this is a bug we must address, or delay the Tab feature for 2.0.

Changed in clicompanion:
importance: Undecided → High
assignee: nobody → CLIcompanion Development Team (clicompanion-devs)
milestone: none → 1.0rc
Duane Hinnen (duanedesign)
Changed in clicompanion:
status: New → Fix Committed
Revision history for this message
naesk (naesk) wrote :

The tabs look great in the 1.0rc version, and this issue appears to be resolved :)

I have discovered two different bugs with the tab feature which I will post separately along with a screencast so as to give a clearer view of the issue.

Revision history for this message
Duane Hinnen (duanedesign) wrote :

One thing I noticed. I was able to create two Tabs with the same name.

summary: - new tab feature does not work quite right
+ Commands run in wrong tab
Revision history for this message
naesk (naesk) wrote :

@duanedesign You have already spotted the bug I was going to do a screencast for :)

The bug only seems to occurs when a user opens more than two new tabs, and then closes an arbitrary number in between the lowest and highest numbered tab. After performing this new tabs added are subsequently numbered with that of the previously closed one.

Revision history for this message
Duane Hinnen (duanedesign) wrote :

clicompanion (1.0-2) maverick; urgency=low

  * Reduced the minimum window size (LP: #614651)
  * Commands now run in correct tabs (LP: #615481)
  * Piped the man command through most (LP: #611141)
  * You can now right-click copy and paste in Terminal (LP: #614789)
  * Help command now filters out Sudo (LP: #611145)
  * Added a scrollbar to the Terminal (LP: #617181)
  * Added the ability to open several Terminals in tabs (LP: #613492)
  * Used naesks logo idea (LP: #608653)
  * You can now exit clicompanion running exit in the Terminal (LP: #611439)

 -- ...Tue, 24 Aug 2010 15:50:12 +0000

Changed in clicompanion:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.