OVN DB Sync always logs warning messages about updating all router ports

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/890799

Reviewed: https://review.opendev.org/c/openstack/neutron/+/890799
Committed: https://opendev.org/openstack/neutron/commit/4693836a1b58b477298e51cb47622222e3556752
Submitter: "Zuul (22348)"
Branch: master

commit 4693836a1b58b477298e51cb47622222e3556752
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue Aug 8 15:17:40 2023 +0100

    [OVN] ovn-db-sync check for router port differences

    Prior to this patch the ovn-db-sync script did not check if the router
    ports were actually out-of-sync before marking them to be updated. This
    behavior introduced irrelevant information in the sync report (specially
    when ran in "log" mode) making the user think that the databases were
    out-of-sync even when they were not.

    This patch adds the code checking for differences in the Neutron Router
    Ports and OVN Logical Router Port entries prior to updating them.

    Change-Id: Id7bf5a6aa547795ba78724eed59ba9d4fb74f758
    Closes-Bug: #2030773
    Signed-off-by: Lucas Alvares Gomes <email address hidden>

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/891501

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/891502

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/891503

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/891504

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/891506

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/892182

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/892183

Reviewed: https://review.opendev.org/c/openstack/neutron/+/891501
Committed: https://opendev.org/openstack/neutron/commit/04541b07209ce56fdd7dd052eae458e11666d9c0
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 04541b07209ce56fdd7dd052eae458e11666d9c0
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue Aug 8 15:17:40 2023 +0100

    [OVN] ovn-db-sync check for router port differences

    Prior to this patch the ovn-db-sync script did not check if the router
    ports were actually out-of-sync before marking them to be updated. This
    behavior introduced irrelevant information in the sync report (specially
    when ran in "log" mode) making the user think that the databases were
    out-of-sync even when they were not.

    This patch adds the code checking for differences in the Neutron Router
    Ports and OVN Logical Router Port entries prior to updating them.

    Conflicts:
      neutron/tests/unit/fake_resources.py

    Change-Id: Id7bf5a6aa547795ba78724eed59ba9d4fb74f758
    Closes-Bug: #2030773
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from commit 4693836a1b58b477298e51cb47622222e3556752)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/891502
Committed: https://opendev.org/openstack/neutron/commit/bc71377ba7f8c99910565969a462c3bd5b8b4379
Submitter: "Zuul (22348)"
Branch: stable/zed

commit bc71377ba7f8c99910565969a462c3bd5b8b4379
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue Aug 8 15:17:40 2023 +0100

    [OVN] ovn-db-sync check for router port differences

    Prior to this patch the ovn-db-sync script did not check if the router
    ports were actually out-of-sync before marking them to be updated. This
    behavior introduced irrelevant information in the sync report (specially
    when ran in "log" mode) making the user think that the databases were
    out-of-sync even when they were not.

    This patch adds the code checking for differences in the Neutron Router
    Ports and OVN Logical Router Port entries prior to updating them.

    Conflicts:
      neutron/tests/unit/fake_resources.py

    Change-Id: Id7bf5a6aa547795ba78724eed59ba9d4fb74f758
    Closes-Bug: #2030773
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from commit 4693836a1b58b477298e51cb47622222e3556752)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/891503
Committed: https://opendev.org/openstack/neutron/commit/b288a1264a07d9590f2280d3cd7476b8117b94b2
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit b288a1264a07d9590f2280d3cd7476b8117b94b2
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue Aug 8 15:17:40 2023 +0100

    [OVN] ovn-db-sync check for router port differences

    Prior to this patch the ovn-db-sync script did not check if the router
    ports were actually out-of-sync before marking them to be updated. This
    behavior introduced irrelevant information in the sync report (specially
    when ran in "log" mode) making the user think that the databases were
    out-of-sync even when they were not.

    This patch adds the code checking for differences in the Neutron Router
    Ports and OVN Logical Router Port entries prior to updating them.

    Conflicts:
      neutron/tests/unit/fake_resources.py

    Change-Id: Id7bf5a6aa547795ba78724eed59ba9d4fb74f758
    Closes-Bug: #2030773
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from commit 4693836a1b58b477298e51cb47622222e3556752)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/891504
Committed: https://opendev.org/openstack/neutron/commit/518751eed355846ee74015d86b08e626928bb962
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 518751eed355846ee74015d86b08e626928bb962
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue Aug 8 15:17:40 2023 +0100

    [OVN] ovn-db-sync check for router port differences

    Prior to this patch the ovn-db-sync script did not check if the router
    ports were actually out-of-sync before marking them to be updated. This
    behavior introduced irrelevant information in the sync report (specially
    when ran in "log" mode) making the user think that the databases were
    out-of-sync even when they were not.

    This patch adds the code checking for differences in the Neutron Router
    Ports and OVN Logical Router Port entries prior to updating them.

    NOTE FOR THIS BACKPORT:

    The lrp_get() method from ovsdbapp is not present for this stable
    branch, so this patch was adapted to use the get_lrouter_port()
    instead.

    Conflicts:
      neutron/tests/unit/fake_resources.py

    Change-Id: Id7bf5a6aa547795ba78724eed59ba9d4fb74f758
    Closes-Bug: #2030773
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from commit 4693836a1b58b477298e51cb47622222e3556752)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/891506
Committed: https://opendev.org/openstack/neutron/commit/1d2a8a679637a72b8171cd276c009766242e14c6
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 1d2a8a679637a72b8171cd276c009766242e14c6
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue Aug 8 15:17:40 2023 +0100

    [OVN] ovn-db-sync check for router port differences

    Prior to this patch the ovn-db-sync script did not check if the router
    ports were actually out-of-sync before marking them to be updated. This
    behavior introduced irrelevant information in the sync report (specially
    when ran in "log" mode) making the user think that the databases were
    out-of-sync even when they were not.

    This patch adds the code checking for differences in the Neutron Router
    Ports and OVN Logical Router Port entries prior to updating them.

    NOTE FOR THIS BACKPORT:

    The lrp_get() method from ovsdbapp is not present for this stable
    branch, so this patch was adapted to use the get_lrouter_port()
    instead.

    Conflicts:
      neutron/tests/unit/fake_resources.py

    Change-Id: Id7bf5a6aa547795ba78724eed59ba9d4fb74f758
    Closes-Bug: #2030773
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from commit 4693836a1b58b477298e51cb47622222e3556752)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/892182
Committed: https://opendev.org/openstack/neutron/commit/8d45ee7f34f339c683c03f5391800b9848aaf11e
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 8d45ee7f34f339c683c03f5391800b9848aaf11e
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue Aug 8 15:17:40 2023 +0100

    [OVN] ovn-db-sync check for router port differences

    Prior to this patch the ovn-db-sync script did not check if the router
    ports were actually out-of-sync before marking them to be updated. This
    behavior introduced irrelevant information in the sync report (specially
    when ran in "log" mode) making the user think that the databases were
    out-of-sync even when they were not.

    This patch adds the code checking for differences in the Neutron Router
    Ports and OVN Logical Router Port entries prior to updating them.

    NOTE FOR THIS BACKPORT:

    The lrp_get() method from ovsdbapp is not present for this stable
    branch, so this patch was adapted to use the get_lrouter_port()
    instead.

    Conflicts:
      neutron/tests/unit/fake_resources.py

    Change-Id: Id7bf5a6aa547795ba78724eed59ba9d4fb74f758
    Closes-Bug: #2030773
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from commit 4693836a1b58b477298e51cb47622222e3556752)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/892183
Committed: https://opendev.org/openstack/neutron/commit/6af6771deb66b75f0189733771e9cc288d6139ed
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 6af6771deb66b75f0189733771e9cc288d6139ed
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue Aug 8 15:17:40 2023 +0100

    [OVN] ovn-db-sync check for router port differences

    Prior to this patch the ovn-db-sync script did not check if the router
    ports were actually out-of-sync before marking them to be updated. This
    behavior introduced irrelevant information in the sync report (specially
    when ran in "log" mode) making the user think that the databases were
    out-of-sync even when they were not.

    This patch adds the code checking for differences in the Neutron Router
    Ports and OVN Logical Router Port entries prior to updating them.

    NOTE FOR THIS BACKPORT:

    The lrp_get() method from ovsdbapp is not present for this stable
    branch, so this patch was adapted to use the get_lrouter_port()
    instead.

    Conflicts:
      neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_db_sync.py
      neutron/tests/unit/fake_resources.py

    Change-Id: Id7bf5a6aa547795ba78724eed59ba9d4fb74f758
    Closes-Bug: #2030773
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from commit 4693836a1b58b477298e51cb47622222e3556752)

This issue was fixed in the openstack/neutron 23.0.0.0b3 development milestone.

This will be fixed in stable point releases for yoga and above in ubuntu. https://review.opendev.org/c/openstack/releases/+/901058

For earlier releases we will pick up the individual patches.

This issue was fixed in the openstack/neutron 22.1.0 release.

This issue was fixed in the openstack/neutron 20.5.0 release.

This issue was fixed in the openstack/neutron 21.2.0 release.

A new package version with this fix has been uploaded to the focal unapproved queue and victoria/wallaby/xena staging PPAs.

Hello Lucas, or anyone else affected,

Accepted neutron into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/neutron/2:16.4.2-0ubuntu6.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

This issue was fixed in the openstack/neutron ussuri-eol release.

Verified this was fixed on a juju-deployed focal/ussuri cloud, no warnings about router ports where with previous 6.3 version there was.

The verification of the Stable Release Update for neutron has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package neutron - 2:16.4.2-0ubuntu6.4

---------------
neutron (2:16.4.2-0ubuntu6.4) focal; urgency=medium

  [ Corey Bryant ]
  * d/p/ovn-db-sync-continue-on-duplicate-normalise.patch: Cherry-picked
    from upstream to allow ovn_db_sync to continue on duplicate normalised
    CIDR (LP: #1961112).
  * d/p/ovn-db-sync-check-for-router-port-differences.patch:
    Cherry-picked from upstream to ensure router ports are marked
    for needing updates only if they have changed (LP: #2030773).
  * d/p/ovn-specify-port-type-if-router-port-when-updating.patch:
    Specify port type if it's a router port when updating to avoid
    port flapping (LP: #1955578).
  * d/p/fix-acl-sync-when-default-sg-group-created.patch:
    Cherry-picked form upstream to fix ACL sync when default security
    group is created (LP: #2008943).

  [ Mustafa Kemal GILOR ]
  * d/p/add_uplink_status_propagation.patch: Add the
    'uplink-status-propagation' extension to ML2/OVN (LP: #2032770).

 -- Corey Bryant <email address hidden> Wed, 08 Nov 2023 11:41:21 -0500

Hello Lucas, or anyone else affected,

Accepted neutron into ussuri-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:ussuri-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-ussuri-needed to verification-ussuri-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-ussuri-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

This issue was fixed in the openstack/neutron victoria-eom release.

This issue was fixed in the openstack/neutron wallaby-eom release.

This issue was fixed in the openstack/neutron xena-eom release.

I have tested neutron version 2:16.4.2-0ubuntu6.4~cloud0 from the cloud-archive:ussuri-proposed repository and can verify the code has this change, and the failure does not occur. I followed the steps from the bug description:

neutron-ovn-db-sync-util --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugins/ml2/ml2_conf.ini --ovn-neutron_sync_mode log

Running that multiple times did not produce out for out of sync ports as is used to.

The verification of the Stable Release Update for neutron has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package neutron - 2:16.4.2-0ubuntu6.4~cloud0
---------------

 neutron (2:16.4.2-0ubuntu6.4~cloud0) bionic-ussuri; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 neutron (2:16.4.2-0ubuntu6.4) focal; urgency=medium
 .
   [ Corey Bryant ]
   * d/p/ovn-db-sync-continue-on-duplicate-normalise.patch: Cherry-picked
     from upstream to allow ovn_db_sync to continue on duplicate normalised
     CIDR (LP: #1961112).
   * d/p/ovn-db-sync-check-for-router-port-differences.patch:
     Cherry-picked from upstream to ensure router ports are marked
     for needing updates only if they have changed (LP: #2030773).
   * d/p/ovn-specify-port-type-if-router-port-when-updating.patch:
     Specify port type if it's a router port when updating to avoid
     port flapping (LP: #1955578).
   * d/p/fix-acl-sync-when-default-sg-group-created.patch:
     Cherry-picked form upstream to fix ACL sync when default security
     group is created (LP: #2008943).
 .
   [ Mustafa Kemal GILOR ]
   * d/p/add_uplink_status_propagation.patch: Add the
     'uplink-status-propagation' extension to ML2/OVN (LP: #2032770).

Hello Lucas, or anyone else affected,

Accepted neutron into wallaby-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:wallaby-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-wallaby-needed to verification-wallaby-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-wallaby-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!