Make pot file generation work again in c-n-f
Bug #1007502 reported by
Gabor Kelemen
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Translations |
Fix Released
|
High
|
Gabor Kelemen | ||
| command-not-found |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
Currently the pot file generation is broken: the po/Makefile is lacking a top_srcdir variable, which makes running intltool-update fail. Therefore, the call to execute cd po && make update-po it is commented out in setup.py.
But wait, if it already uses python-distutils, why not just use its built-in i18n handling facilities, instead of this custom Makefile?
I'm attaching a branch that makes life simpler by replacing po/Makefile with the build_i18n function from python-
Side note: this was circumvented in bug #549106 on the Ubuntu level, but only there, and only until the latest rewrite of debian/rules[1]. I hope this solution is going to be more futureproof :).
Related branches
lp://qastaging/~kelemeng/command-not-found/bug1007502
- Zygmunt Krynicki: Approve
-
Diff: 241 lines (+108/-55)4 files modifiedpo/Makefile (+0/-24)
po/POTFILES.in (+1/-0)
po/command-not-found.pot (+102/-20)
setup.py (+5/-11)
| Changed in ubuntu-translations: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| assignee: | nobody → Gabor Kelemen (kelemeng) |
| tags: | added: needs-pot-on-build |
| Changed in ubuntu-translations: | |
| status: | Triaged → Fix Committed |
| Changed in command-not-found: | |
| status: | New → Fix Committed |
| Changed in command-not-found: | |
| status: | Fix Committed → Fix Released |
| Changed in ubuntu-translations: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
