Compiz

Regression, r3728: Now Guake, Terra and other drop-down terminals are too large and extend to the right side into the next screen

Bug #1186723 reported by MC Return
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Compiz
Fix Released
Medium
Unassigned
Compiz 0.9.10.0

Bug Description

Top-left corner is correct now, but the terminals open too large and partially overlap into the next screen :(

In the case of Guake this makes the button to open a new tab unreachable on a single-screen system.

Related branches

lp://qastaging/~compiz-team/compiz/compiz.fix_1186723
PS Jenkins bot (community): Needs Fixing (continuous-integration)
Sam Spilsbury: Disapprove
Diff: 249 lines (+105/-54)
2 files modified
gtk/window-decorator/tests/test_gwd_settings.cpp (+98/-51)
plugins/decor/src/decor.cpp (+7/-3)
Revision history for this message
MC Return (mc-return) wrote :

In decor.cpp, this seems to be wrong:

37 + int dwidth = sizeDelta.width () - lastSizeDelta.height ();

I'll propose a fix...

MC Return (mc-return)
Changed in compiz:
assignee: nobody → MC Return (mc-return)
milestone: none → 0.9.10.0
importance: Undecided → Medium
status: New → In Progress
summary: - Regression: Now Guake, Terra and other drop-down terminals are too large
- and extend to the right side into the next screen
+ Regression, r3728: Now Guake, Terra and other drop-down terminals are
+ too large and extend to the right side into the next screen
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

This is really why the decor plugin needs an acceptance test suite ... this is yet another corner case that I wasn't able to test myself.

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

I have a fix for both this and bug 116560 , but ...

I'm not a huge fan of the way things are working at the moment. I think we really need a proper testsuite around this functionality before we land any more fixes. A lot of the behavior around maximization and decoration is very very tightly coupled and fixing one thing often breaks another.

I'll post the fixes up for a test-only review, but I think we should hold any further work here until the acceptance test suite is delivered. I'll make that a top priority.

Revision history for this message
MC Return (mc-return) wrote :

r3728 has been reverted in r3736 (see here: https://code.launchpad.net/~compiz-team/compiz/compiz.revert_3728/+merge/167894 )
Setting to "Fix Committed".

Changed in compiz:
assignee: MC Return (mc-return) → nobody
status: In Progress → Triaged
status: Triaged → Fix Committed
Revision history for this message
Stephen M. Webb (bregma) wrote :

Fix Released in Compiz Compiz 0.9.10.0.

Changed in compiz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.