All transfers are disappearing from TransferView when enabled/disabled

Bug #666461 reported by eMTee
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
DC++
Confirmed
Low
Unassigned

Bug Description

Existing transfers are disappear from TransferView when you disable and re-enable it with Ctrl-2
XP SP3, r2259

Tags: dwt win32-ui
Revision history for this message
iceman50 (bdcdevel) wrote :

confirmed on windows 7 home premium 32 bit

Changed in dcplusplus:
status: New → Confirmed
Fredrik Ullner (ullner)
Changed in dcplusplus:
status: Confirmed → In Progress
assignee: nobody → Fredrik Ullner (ullner)
Revision history for this message
poy (poy) wrote :

i have tried to tackle this before but could not find any satisfying solution... please discuss the general direction(s) before going too far.

Revision history for this message
Fredrik Ullner (ullner) wrote :

The attached patch was what I had intended and it works here, although it is incomplete.

Revision history for this message
poy (poy) wrote :

i can think of 2 main directions:
A) add methods in event generating classes to retrieve lists of previously consumed events (what the patch is doing).
B) keep a cache on the observer side (the GUI).

pros of #B:
- no thread-related problems.
- easy to implement.

con of #B:
- consumes resources even when the transfer panel is hidden.

the only advantage i can see of #A is to avoid that resource consumption problem. i am wondering if it is worth the following cons:
1) retrieving connections is probably not enough; there are also downloads and (optionally) HTTP transfers.
2) thread safety (around the todo - std::copy / std::transfer might come in handy).
3) check what happens when the same event is received twice; once by the retrieving func, once through a regular callback.

Revision history for this message
Fredrik Ullner (ullner) wrote :

The attached patch will take care of all connections and try and show them when you re-open...

The only thing that I could see is when you close a Connection (and still is closing), it won't show up when you re-open the window, but I don't think that that scenario occur very often and is kind of irrelevant as well.

Revision history for this message
Fredrik Ullner (ullner) wrote :

Hm, I didn't see comment #4, I'll reconsider.

Fredrik Ullner (ullner)
tags: added: dwt win32-ui
Fredrik Ullner (ullner)
Changed in dcplusplus:
status: In Progress → Confirmed
assignee: Fredrik Ullner (ullner) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.