DC++

portable semaphore implementation

Bug #804559 reported by Gennady Proskurin on 2011-07-01

This bug affects 1 person

	Status	Importance	Assigned to
AirDC++	Confirmed	Low	Unassigned
DC++	Confirmed	Low	Jacek Sieka
StrongDC++	Confirmed	Undecided	Unassigned

Bug Description

Portable "class Semaphore" implementation using boost::interprocess_semaphore.
Patch attached.

Tags:

Revision history for this message

Gennady Proskurin (gpr) wrote on 2011-07-01:

sem.patch Edit (2.0 KiB, text/plain)

eMTee (realprogger) on 2011-08-24

Changed in dcplusplus:
status:	New → Confirmed
importance:	Undecided → Low
assignee:	nobody → Jacek Sieka (arnetheduck)

Big Muscle (bigmuscle) on 2011-08-24

Changed in strongdc:
status:	New → Confirmed

Revision history for this message

Gennady Proskurin (gpr) wrote on 2011-08-25:

btw, boost1.47 has issues with interprocess_semaphore
see boost bug https://svn.boost.org/trac/boost/ticket/4524
I think my patch should not be merged until boost bug 4524 is resolved

I keep an eye on bug 4524 and will drop a note here

Revision history for this message

Big Muscle (bigmuscle) wrote on 2011-08-26:

Thanks for your information. I also suggest dropping Semaphore class completely and use boost semaphore directly (of course, when the bug is fixed).

Fredrik Ullner (ullner) on 2013-11-30

tags:

added: core

maksis (maksis) on 2013-12-01

Changed in airdcpp:
status:	New → Confirmed
importance:	Undecided → Low

Revision history for this message

Fredrik Ullner (ullner) wrote on 2015-10-08:

dcpp_semaphore.diff Edit (1.9 KiB, text/plain)

As far as I can tell, this is fixed in newer version of Boost (that we are using). I propose we finally apply this patch (included is a diff against the current code base).

Changed in dcplusplus:
status:	Confirmed → In Progress

Fredrik Ullner (ullner) on 2016-01-03

Changed in dcplusplus:
status:	In Progress → Fix Committed

Revision history for this message

poy (poy) wrote on 2016-01-04:

the patch submitted by Gennady <https://svn.boost.org/trac/boost/attachment/ticket/4524/ipc_sem.patch> has not been applied in the version of boost currently in the DC++ repo.

at a first glance at the file in question, this might affect Windows builds (Windows-specific stuff is within an elif-guard that comes after the if-guard changed by the patch).

Revision history for this message

Fredrik Ullner (ullner) wrote on 2016-01-04:

Fair enough, I've reverted the code in DC++ (hopefully didn't break the repository).