apt-avahi-discover script uses deprecated asyncore module

Status changed to 'Confirmed' because the bug affects multiple users.

https://github.com/mvo5/squid-deb-proxy/blob/main/apt-avahi-discover
has been converted to use asyncio.

Then SRU is needed.

SRU - Someone Really Useful? I am a noob who is good at research but point me in the right direction and I'll try and figure it out.

https://wiki.ubuntu.com/StableReleaseUpdates with mvo5 help.

Well, he's a member of Conanical, all I could do is get in the way, well above my paygrade.. LOL

But thanks for the information, it gives me a better understanding of how this works!

If someone will point me to a "how to submit patch" howto, I'll submit a patch.

@Carl, the first step is to fix this problem in the current development release.

I have backported the latest upstream apt-avahi-discover script to lunar. I also compiled the package for jammy and it works fine. Feel free to get the fixed package for jammy and later from my stable LTS support PPA.

@sponsors, please consider to upload the following debdiff to lunar

I have just sponsored your debdiff to lunar - thanks @r0lf

Thanks, Alex. Much appreciated!

This bug was fixed in the package squid-deb-proxy - 0.8.15+nmu1ubuntu2

---------------
squid-deb-proxy (0.8.15+nmu1ubuntu2) lunar; urgency=medium

  * backport latest apt-avahi-discover from upstream commit
    42fe9174a408436329e8a0b8b48fb19b2d000d4d
    - fix flake8 style errors
    - transition from asyncore to asyncio (LP: #1963794)

 -- Rolf Leggewie <email address hidden> Wed, 04 Jan 2023 10:53:24 +0800

I run this updated package recompiled in jammy. I believe the fix might introduce a regression from upstream. Reopening for verification in lunar.

I run an instance of apt-cacher-ng on my local machine. When the instance is active, things are great. When I turn it off with "sudo service apt-cacher-ng stop" and then run the /usr/share/squid-deb-proxy-client/apt-avahi-discover script, I get the following error. This does not happen with the package still using asyncore. Can somebody please verify?

$ /usr/share/squid-deb-proxy-client/apt-avahi-discover
Traceback (most recent call last):
  File "/usr/share/squid-deb-proxy-client/apt-avahi-discover", line 148, in <module>
    address = get_proxy_host_port_from_avahi()
  File "/usr/share/squid-deb-proxy-client/apt-avahi-discover", line 131, in get_proxy_host_port_from_avahi
    asyncio.run(asyncio.wait_for(gather_hosts(), timeout=timeout))
  File "/usr/lib/python3.10/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/usr/lib/python3.10/asyncio/base_events.py", line 646, in run_until_complete
    return future.result()
  File "/usr/lib/python3.10/asyncio/tasks.py", line 445, in wait_for
    return fut.result()
  File "/usr/share/squid-deb-proxy-client/apt-avahi-discover", line 128, in gather_hosts
    await asyncio.gather(*[h.time_connect() for h in hosts])
  File "/usr/share/squid-deb-proxy-client/apt-avahi-discover", line 51, in time_connect
    reader, writer = await asyncio.open_connection(
  File "/usr/lib/python3.10/asyncio/streams.py", line 47, in open_connection
    transport, _ = await loop.create_connection(
  File "/usr/lib/python3.10/asyncio/base_events.py", line 1064, in create_connection
    raise exceptions[0]
  File "/usr/lib/python3.10/asyncio/base_events.py", line 1049, in create_connection
    sock = await self._connect_sock(
  File "/usr/lib/python3.10/asyncio/base_events.py", line 960, in _connect_sock
    await self.sock_connect(sock, address)
  File "/usr/lib/python3.10/asyncio/selector_events.py", line 500, in sock_connect
    return await fut
  File "/usr/lib/python3.10/asyncio/selector_events.py", line 535, in _sock_connect_cb
    raise OSError(err, f'Connect call failed {address}')
ConnectionRefusedError: [Errno 111] Connect call failed ('172.17.0.1', 3142)

Regression confirmed by Gunnar in lunar in bug 2002562 comment 2

There is a fix to the regression available and I verified it does the job at least in my case

https://github.com/mvo5/squid-deb-proxy/pull/9

This bug was fixed in the package squid-deb-proxy - 0.8.15+nmu1ubuntu4

---------------
squid-deb-proxy (0.8.15+nmu1ubuntu4) lunar; urgency=medium

  * fix regression from LP: #1963794 with patch from Jesse McDonald

 -- Rolf Leggewie <email address hidden> Sat, 21 Jan 2023 09:39:59 +0100

Will this fix be rolled out to jammy?

I can confirm that 0.8.15+nmu1ubuntu4 works on 22.04.2.

Testing done:
wget https://launchpad.net/ubuntu/+archive/primary/+files/squid-deb-proxy-client_0.8.15+nmu1ubuntu4_all.deb
apt-get install ./squid-deb-proxy-client_0.8.15+nmu1ubuntu4_all.deb
reboot now

/usr/share/squid-deb-proxy-client/apt-avahi-discover
http://192.168.50.101:3142/

Please upload this fixed package to the upcoming Debian 12 (bookworm) repository.

This is still an issue on Jammy 22.04.3. Its only available here, I followed the testing from #17 and it worked fine, and I didn't actually need to reboot for the errors in apt-get update to disappear.