xserver-xorg-video-nouveau 1:1.0.17-3 FTBFS on armhf

Bug #2062144 reported by Benjamin Drung
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
xorg-server (Debian)
Confirmed
Unknown
xorg-server (Ubuntu)
Invalid
Undecided
Unassigned
Noble
Invalid
Undecided
Unassigned
Oracular
Invalid
Undecided
Unassigned
xserver-xorg-video-nouveau (Ubuntu)
Fix Released
Undecided
Unassigned
Noble
Fix Committed
Undecided
Unassigned
Oracular
Fix Released
Undecided
Unassigned

Bug Description

[Impact]

xserver-xorg-video-nouveau 1:1.0.17-3 fails to build on armhf:

```
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../../src -I.. -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64 -Wdate-time -D_FORTIFY_SOURCE=3 -I/usr/include/xorg -fvisibility=hidden -I/usr/include/pixman-1 -I/usr/include/X11/dri -I/usr/include/libdrm -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/usr/include/libdrm -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -fno-stack-clash-protection -fdebug-prefix-map=/<<PKGBUILDDIR>>=/usr/src/xserver-xorg-video-nouveau-1:1.0.17-3 -Wall -I/usr/include/xorg -fvisibility=hidden -I/usr/include/pixman-1 -I/usr/include/X11/dri -I/usr/include/libdrm -c ../../src/nv_shadow.c -fPIC -DPIC -o .libs/nv_shadow.o
../../src/nv_driver.c: In function ‘NVScreenInit’:
../../src/nv_driver.c:1451:23: error: implicit declaration of function ‘wfbScreenInit’; did you mean ‘fbScreenInit’? [-Werror=implicit-function-declaration]
 1451 | ret = wfbScreenInit(pScreen, FBStart, pScrn->virtualX,
      | ^~~~~~~~~~~~~
      | fbScreenInit
```

This failure is fixed upstream in xorg-server via https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1114

[Test Plan]

The package needs to build for armhf

[Where problems could occur]

The patch adds function prototypes explicitly. If the function signature does not match, the code will still compile, but the behaviour will be undefined.
This would not happen as the package only needs the inline definitions for armhf.
On other architectures the header is included correctly and the compiler will produce a 'conflicting types' error.

[Other Info]

n/a

Related branches

Benjamin Drung (bdrung)
description: updated
Changed in xorg-server (Debian):
status: Unknown → Confirmed
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

the upstream backport request has more context

https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1222

and it's not clear that this wouldn't be a bug in nouveau instead

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in xorg-server (Ubuntu):
status: New → Confirmed
Changed in xserver-xorg-video-nouveau (Ubuntu):
status: New → Confirmed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xserver-xorg-video-nouveau - 1:1.0.17-3ubuntu1

---------------
xserver-xorg-video-nouveau (1:1.0.17-3ubuntu1) oracular; urgency=medium

  * d/p/nouveau-fixup-driver-for-new-macro-gating.patch:
    fix implicit declarations (LP: #2062144).
  * d/source/format: upgrade to "3.0 (quilt)" format.

 -- Zixing Liu <email address hidden> Mon, 01 Jul 2024 13:52:21 -0600

Changed in xserver-xorg-video-nouveau (Ubuntu):
status: Confirmed → Fix Released
Jeremy Bícha (jbicha)
Changed in xorg-server (Ubuntu):
status: Confirmed → Fix Released
status: Fix Released → Triaged
Vladimir Petko (vpa1977)
description: updated
Changed in xserver-xorg-video-nouveau (Ubuntu Noble):
status: New → In Progress
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello Benjamin, or anyone else affected,

Accepted xserver-xorg-video-nouveau into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/xserver-xorg-video-nouveau/1:1.0.17-2ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in xserver-xorg-video-nouveau (Ubuntu Noble):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-noble
Changed in xorg-server (Ubuntu Oracular):
status: Triaged → Invalid
Changed in xorg-server (Ubuntu Noble):
status: New → Invalid
Changed in xorg-server (Ubuntu):
status: Triaged → Invalid
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

builds on armhf now

tags: added: verification-done verification-done-noble
removed: verification-needed verification-needed-noble
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.