dee

dee_serializable_serialize must return non-floating variant

Bug #916783 reported by Michal Hruby
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Unity
Fix Released
Undecided
Unassigned
dee
Fix Released
Medium
Michal Hruby
dee 1.0.2 "Ahab"
dee (Ubuntu)
Fix Released
Undecided
Unassigned
unity (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Currently the documentation for dee_serializable_serialize says that the return value is a floating reference to a GVariant and it is also used in this way in methods like dee_serializable_externalize, but since the serialize method is virtual, we cannot make this assumption, as implementors of DeeSerializable may just return a cached GVariant. Although this is a subtle API-break, we should do it (ultimately this change introduces "only" a memory leak, which is already there anyway if they return non-floating reference).

Related branches

lp://qastaging/~mhr3/dee/floating-and-sinking
Mikkel Kamstrup Erlandsen (community): Approve
Diff: 106 lines (+24/-6)
4 files modified
src/dee-serializable.c (+13/-4)
vapi/Dee-1.0-custom.vala (+7/-0)
vapi/Dee-1.0.metadata (+1/-0)
vapi/dee-1.0.vapi (+3/-2)
Michal Hruby (mhr3)
Changed in dee:
assignee: nobody → Michal Hruby (mhr3)
importance: Undecided → Low
importance: Low → Medium
Michal Hruby (mhr3)
Changed in dee:
status: New → In Progress
Unity Merger (unity-merger)
Changed in dee:
status: In Progress → Fix Committed
Mikkel Kamstrup Erlandsen (kamstrup)
Changed in dee:
milestone: none → 1.0.2
Didier Roche-Tolomelli (didrocks)
Changed in unity:
status: New → Fix Committed
Changed in dee (Ubuntu):
status: New → Fix Committed
Mikkel Kamstrup Erlandsen (kamstrup)
Changed in dee:
status: Fix Committed → Fix Released
Omer Akram (om26er)
Changed in unity:
status: Fix Committed → Fix Released
Changed in dee (Ubuntu):
status: Fix Committed → Fix Released
Marco Trevisan (Treviño) (3v1n0)
Changed in unity (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.