test-run.pl needs work around the --secure-file-priv option
Bug #675799 reported by
Patrick Crews
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Drizzle |
Fix Released
|
Low
|
Patrick Crews | ||
| 7.0 |
Fix Released
|
Low
|
Patrick Crews | ||
Bug Description
test-run.pl starts the test server with --secure-file-priv = $VARDIR. This is for security reasons.
However, there are cases where we either want to use a different directory (tools such as the randgen use LOADDATA operations for things like BLOB columns) or no directory at all.
test-run.pl needs to be altered to not try to specify $VARDIR as an argument to --secure-file-priv if the user supplies their own argument; the server will not start if two such arguments are passed to the server. Drizzle doesn't support multiple arguments (don't see the need to introduce such behavior) and having the last option supersede previous options is a bit sloppy.
Will also add a --no-secure-
Related branches
lp://qastaging/~patrick-crews/drizzle/project_steve_austin
- Patrick Crews: Needs Resubmitting
- Lee Bieber (community): Needs Fixing
-
Diff: 4137 lines (+3158/-95)87 files modified.bzrignore (+1/-0)
plugin/filesystem_engine/tests/r/basic_create_table.result (+6/-6)
plugin/filesystem_engine/tests/r/basic_delete.result (+1/-1)
plugin/filesystem_engine/tests/r/basic_insert.result (+1/-1)
plugin/filesystem_engine/tests/r/basic_select.result (+1/-1)
plugin/filesystem_engine/tests/r/basic_update.result (+1/-1)
plugin/filesystem_engine/tests/r/multiple_update.result (+1/-1)
plugin/filesystem_engine/tests/r/rnd_pos.result (+1/-1)
plugin/filesystem_engine/tests/r/select_big_file.result (+1/-1)
plugin/filesystem_engine/tests/r/select_chop_line.result (+1/-1)
plugin/filesystem_engine/tests/r/select_cpuinfo.result (+2/-2)
plugin/filesystem_engine/tests/r/select_meminfo.result (+2/-2)
plugin/filesystem_engine/tests/r/select_separator_mode_weak.result (+1/-1)
plugin/filesystem_engine/tests/r/select_short_line.result (+1/-1)
plugin/filesystem_engine/tests/r/select_skip_blank_line.result (+1/-1)
plugin/filesystem_engine/tests/r/select_with_escaped_character.result (+1/-2)
plugin/filesystem_engine/tests/r/select_with_omit_field.result (+1/-1)
plugin/filesystem_engine/tests/r/select_with_separators.result (+1/-1)
plugin/filesystem_engine/tests/t/basic_create_table.test (+11/-5)
plugin/filesystem_engine/tests/t/basic_delete.test (+2/-1)
plugin/filesystem_engine/tests/t/basic_insert.test (+2/-1)
plugin/filesystem_engine/tests/t/basic_select.test (+2/-1)
plugin/filesystem_engine/tests/t/basic_update.test (+2/-1)
plugin/filesystem_engine/tests/t/multiple_update.test (+2/-1)
plugin/filesystem_engine/tests/t/rnd_pos.test (+3/-2)
plugin/filesystem_engine/tests/t/select_big_file.test (+2/-1)
plugin/filesystem_engine/tests/t/select_chop_line.test (+2/-1)
plugin/filesystem_engine/tests/t/select_cpuinfo.test (+3/-1)
plugin/filesystem_engine/tests/t/select_meminfo.test (+3/-1)
plugin/filesystem_engine/tests/t/select_separator_mode_weak.test (+2/-1)
plugin/filesystem_engine/tests/t/select_short_line.test (+2/-1)
plugin/filesystem_engine/tests/t/select_skip_blank_line.test (+2/-1)
plugin/filesystem_engine/tests/t/select_with_escaped_character.test (+2/-2)
plugin/filesystem_engine/tests/t/select_with_omit_field.test (+3/-2)
plugin/filesystem_engine/tests/t/select_with_separators.test (+3/-2)
plugin/filtered_replicator/tests/t/var_filteredschemas.test (+2/-1)
plugin/filtered_replicator/tests/t/var_filteredtables.test (+2/-2)
plugin/filtered_replicator/tests/t/var_schemaregex.test (+2/-1)
plugin/filtered_replicator/tests/t/var_tableregex.test (+2/-2)
plugin/innobase/tests/t/innodb_bug53756-master.opt (+0/-1)
plugin/storage_engine_api_tester/tests/t/txn_log_insert.test (+2/-2)
plugin/storage_engine_api_tester/tests/t/txn_log_rollback_large_stmt.test (+2/-1)
plugin/transaction_log/tests/r/truncate_log.result (+2/-2)
plugin/transaction_log/tests/t/alter.test (+2/-2)
plugin/transaction_log/tests/t/alter_schema.test (+2/-1)
plugin/transaction_log/tests/t/auto_commit.test (+2/-1)
plugin/transaction_log/tests/t/blob.test (+2/-1)
plugin/transaction_log/tests/t/create_select.test (+2/-1)
plugin/transaction_log/tests/t/create_table.test (+2/-1)
plugin/transaction_log/tests/t/delete.test (+2/-1)
plugin/transaction_log/tests/t/embedded_quotes.test (+2/-1)
plugin/transaction_log/tests/t/insert.test (+2/-1)
plugin/transaction_log/tests/t/insert_multi.test (+2/-1)
plugin/transaction_log/tests/t/insert_on_duplicate_update.test (+2/-1)
plugin/transaction_log/tests/t/insert_select.test (+2/-1)
plugin/transaction_log/tests/t/multi_column_primary_key.test (+2/-1)
plugin/transaction_log/tests/t/multi_table.test (+2/-1)
plugin/transaction_log/tests/t/no_modification.test (+2/-1)
plugin/transaction_log/tests/t/no_primary_key.test (+2/-1)
plugin/transaction_log/tests/t/null_values.test (+2/-1)
plugin/transaction_log/tests/t/rand.test (+2/-1)
plugin/transaction_log/tests/t/rename.test (+2/-1)
plugin/transaction_log/tests/t/replace.test (+2/-1)
plugin/transaction_log/tests/t/rollback.test (+2/-1)
plugin/transaction_log/tests/t/rollback_statement.test (+4/-3)
plugin/transaction_log/tests/t/schema.test (+2/-1)
plugin/transaction_log/tests/t/select_for_update.test (+2/-1)
plugin/transaction_log/tests/t/temp_tables.test (+2/-2)
plugin/transaction_log/tests/t/truncate.test (+2/-1)
plugin/transaction_log/tests/t/truncate_log.test (+4/-2)
plugin/transaction_log/tests/t/update.test (+2/-1)
tests/dbqp.py (+72/-0)
tests/include.am (+4/-0)
tests/lib/drizzle_test_run/dtr_test_execution.py (+159/-0)
tests/lib/drizzle_test_run/dtr_test_management.py (+393/-0)
tests/lib/server_mgmt/drizzled.py (+269/-0)
tests/lib/server_mgmt/server_management.py (+299/-0)
tests/lib/sys_mgmt/codeTree.py (+151/-0)
tests/lib/sys_mgmt/logging_management.py (+103/-0)
tests/lib/sys_mgmt/port_management.py (+172/-0)
tests/lib/sys_mgmt/system_management.py (+438/-0)
tests/lib/sys_mgmt/time_management.py (+103/-0)
tests/lib/test_mgmt/execution_management.py (+121/-0)
tests/lib/test_mgmt/test_execution.py (+145/-0)
tests/lib/test_mgmt/test_management.py (+264/-0)
tests/lib/test_mode.py (+45/-0)
tests/lib/test_run_options.py (+273/-0)
| Changed in drizzle: | |
| assignee: | nobody → Patrick Crews (patrick-crews) |
| status: | New → Confirmed |
| importance: | Undecided → Low |
| Changed in drizzle: | |
| assignee: | Patrick Crews (patrick-crews) → nobody |
| assignee: | nobody → Vijay Samuel (vjsamuel) |
Revision history for this message
| Patrick Crews (patrick-crews) wrote | #1 |
| Changed in drizzle: | |
| assignee: | Vijay Samuel (vjsamuel) → Patrick Crews (patrick-crews) |
| status: | Confirmed → Fix Committed |
| milestone: | none → future |
Revision history for this message
| Lee Bieber (kalebral-deactivatedaccount) wrote | #2 |
To post a comment you must log in.
new test-runner project has no-secure-file priv option that *won't* set --secure-file-priv = vardir for servers