Drizzle

Include transaction_reader in Drizzle installations

Bug #746580 reported by David Shrewsbury
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Drizzle
Fix Released
Low
David Shrewsbury
Drizzle 2011-04-11
7.0
Fix Released
Low
David Shrewsbury
Drizzle 2011-04-11
7.1
Fix Released
Low
David Shrewsbury
Drizzle 2011-04-11

Bug Description

Currently, the transaction_reader utility is not installed. It is only available if you build the source. This is a useful tool that should be included in Drizzle packaging.

Related branches

lp://qastaging/~patrick-crews/drizzle/dbqp_tweak_trx_reader (Merged)
lp://qastaging/~dshrews/drizzle/bug746580_fremont
Lee Bieber: Pending requested
Diff: 646 lines (+68/-63)
39 files modified
.bzrignore (+1/-2)
plugin/filtered_replicator/tests/t/var_filteredschemas.test (+1/-1)
plugin/filtered_replicator/tests/t/var_filteredtables.test (+1/-1)
plugin/filtered_replicator/tests/t/var_schemaregex.test (+1/-1)
plugin/filtered_replicator/tests/t/var_tableregex.test (+1/-1)
plugin/storage_engine_api_tester/tests/t/txn_log_insert.test (+1/-1)
plugin/storage_engine_api_tester/tests/t/txn_log_rollback_large_stmt.test (+1/-1)
plugin/transaction_log/plugin.am (+4/-4)
plugin/transaction_log/tests/t/alter.test (+2/-2)
plugin/transaction_log/tests/t/alter_schema.test (+1/-1)
plugin/transaction_log/tests/t/auto_commit.test (+2/-2)
plugin/transaction_log/tests/t/blob.test (+2/-2)
plugin/transaction_log/tests/t/create_select.test (+2/-2)
plugin/transaction_log/tests/t/create_table.test (+2/-2)
plugin/transaction_log/tests/t/delete.test (+2/-2)
plugin/transaction_log/tests/t/embedded_quotes.test (+1/-1)
plugin/transaction_log/tests/t/insert.test (+2/-2)
plugin/transaction_log/tests/t/insert_multi.test (+2/-2)
plugin/transaction_log/tests/t/insert_on_duplicate_update.test (+2/-2)
plugin/transaction_log/tests/t/insert_select.test (+2/-2)
plugin/transaction_log/tests/t/multi_column_primary_key.test (+2/-2)
plugin/transaction_log/tests/t/multi_table.test (+2/-2)
plugin/transaction_log/tests/t/no_modification.test (+2/-2)
plugin/transaction_log/tests/t/no_primary_key.test (+2/-2)
plugin/transaction_log/tests/t/null_values.test (+2/-2)
plugin/transaction_log/tests/t/rand.test (+2/-2)
plugin/transaction_log/tests/t/rename.test (+2/-2)
plugin/transaction_log/tests/t/replace.test (+2/-2)
plugin/transaction_log/tests/t/rollback.test (+2/-2)
plugin/transaction_log/tests/t/rollback_statement.test (+2/-2)
plugin/transaction_log/tests/t/schema.test (+2/-2)
plugin/transaction_log/tests/t/select_for_update.test (+2/-2)
plugin/transaction_log/tests/t/temp_tables.test (+1/-1)
plugin/transaction_log/tests/t/truncate.test (+1/-1)
plugin/transaction_log/tests/t/update.test (+2/-2)
tests/lib/drizzle_test_run/dtr_test_execution.py (+1/-0)
tests/lib/randgen/randgen_test_execution.py (+2/-1)
tests/lib/sys_mgmt/codeTree.py (+3/-0)
tests/test-run.pl (+1/-0)
lp://qastaging/~dshrews/drizzle/bug746580_elliott
Drizzle Developers: Pending requested
Diff: 646 lines (+68/-63)
39 files modified
.bzrignore (+1/-2)
plugin/filtered_replicator/tests/t/var_filteredschemas.test (+1/-1)
plugin/filtered_replicator/tests/t/var_filteredtables.test (+1/-1)
plugin/filtered_replicator/tests/t/var_schemaregex.test (+1/-1)
plugin/filtered_replicator/tests/t/var_tableregex.test (+1/-1)
plugin/storage_engine_api_tester/tests/t/txn_log_insert.test (+1/-1)
plugin/storage_engine_api_tester/tests/t/txn_log_rollback_large_stmt.test (+1/-1)
plugin/transaction_log/plugin.am (+4/-4)
plugin/transaction_log/tests/t/alter.test (+2/-2)
plugin/transaction_log/tests/t/alter_schema.test (+1/-1)
plugin/transaction_log/tests/t/auto_commit.test (+2/-2)
plugin/transaction_log/tests/t/blob.test (+2/-2)
plugin/transaction_log/tests/t/create_select.test (+2/-2)
plugin/transaction_log/tests/t/create_table.test (+2/-2)
plugin/transaction_log/tests/t/delete.test (+2/-2)
plugin/transaction_log/tests/t/embedded_quotes.test (+1/-1)
plugin/transaction_log/tests/t/insert.test (+2/-2)
plugin/transaction_log/tests/t/insert_multi.test (+2/-2)
plugin/transaction_log/tests/t/insert_on_duplicate_update.test (+2/-2)
plugin/transaction_log/tests/t/insert_select.test (+2/-2)
plugin/transaction_log/tests/t/multi_column_primary_key.test (+2/-2)
plugin/transaction_log/tests/t/multi_table.test (+2/-2)
plugin/transaction_log/tests/t/no_modification.test (+2/-2)
plugin/transaction_log/tests/t/no_primary_key.test (+2/-2)
plugin/transaction_log/tests/t/null_values.test (+2/-2)
plugin/transaction_log/tests/t/rand.test (+2/-2)
plugin/transaction_log/tests/t/rename.test (+2/-2)
plugin/transaction_log/tests/t/replace.test (+2/-2)
plugin/transaction_log/tests/t/rollback.test (+2/-2)
plugin/transaction_log/tests/t/rollback_statement.test (+2/-2)
plugin/transaction_log/tests/t/schema.test (+2/-2)
plugin/transaction_log/tests/t/select_for_update.test (+2/-2)
plugin/transaction_log/tests/t/temp_tables.test (+1/-1)
plugin/transaction_log/tests/t/truncate.test (+1/-1)
plugin/transaction_log/tests/t/update.test (+2/-2)
tests/lib/drizzle_test_run/dtr_test_execution.py (+1/-0)
tests/lib/randgen/randgen_test_execution.py (+2/-1)
tests/lib/sys_mgmt/codeTree.py (+3/-0)
tests/test-run.pl (+1/-0)
Revision history for this message
Monty Taylor (mordred) wrote : Re: [Bug 746580] [NEW] Include transaction_reader in Drizzle installations

On 03/31/2011 01:11 PM, David Shrewsbury wrote:
> Public bug reported:
>
> Currently, the transaction_reader utility is not installed. It is only
> available if you build the source. This is a useful tool that should be
> included in Drizzle packaging.

If we're going to install it - we should read name it -
transaction_reader is a bit generic. Perhaps drizzle_transaction_reader
or something?

Also - be sure to ping Derks and I about this when you get a patch that
moves it from noinst_PROGRAMS to bin_PROGRAMS so that we can update the
debs/rpms appropriately.

AND - I nominate this for elliott. Having that program installed won't
break anyone's existing setups, and it is in fact a useful thing.

Monty

Revision history for this message
Patrick Crews (patrick-crews) wrote :

My attached branch adds a DRIZZLE_TRX_READER env var that tests can now call (versus the path).
Adjusted transaction_log tests accordingly.

When / if you change the trx_reader name / path, just modify this code to reflect the proper path:
=== modified file 'tests/lib/sys_mgmt/codeTree.py'
--- tests/lib/sys_mgmt/codeTree.py 2011-03-23 18:56:05 +0000
+++ tests/lib/sys_mgmt/codeTree.py 2011-03-31 19:19:53 +0000
@@ -103,6 +103,9 @@
         self.drizzletest = self.system_manager.find_path([os.path.join(self.clientbindir,
                                                    'drizzletest')])

+ self.drizzle_trx_reader = self.system_manager.find_path([os.path.join(self.basedir,
+ 'plugin/transaction_log/utilities/transaction_reader')])
+
         self.server_version_string = None
         self.server_executable = None
         self.server_version = None

Revision history for this message
David Shrewsbury (dshrews) wrote :

Renaming transaction_reader to drizzle_trx_reader.

Revision history for this message
David Shrewsbury (dshrews) wrote :

Using 'drizzletrx' as the name instead, after IRC discussion.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.