Web Client: Columns Missing from Group Member Details

Evergreen 3.1.6

Thanks for the comparison, John!

Just commenting:
For us, the most important columns to add would be:
Current Library Card
Privilege Expiration Date (#1779743)
Home Library
Items Lost

Fixing a typo in my description:

For us, *Items LOST* is the most important as it helps us determine what is contributing to the Total Owed/Balance Owed fields on the screen.

Looks like this is still an issue in 3.6.

Noting that that XUL used open-ils.actor.user.checked_out.count.authoritative to retrieve the circ counts, including lost items, and open-ils.actor.usergroup.members.balance_owed.authoritative to retrieve the balance owed.

The AngularJS interface does neither.

The experimental Angular interface uses open-ils.actor.user.opac.vital_stats.authoritative to get the balanced owed and the counts of items out and overdue, but does not currently grab the count of items lost.

We upgraded to 3.11.4 in Mid-March, and we now have the "privilege expiration date" column available in the group member details column...BUT it never populates the data when you first open the screen--you have to go in and manipulate a column for the column to have data in it.

We are on 3.12.5 and I just tested and the privilege expiration date does continue to not populate when you first open the screen. I was able to just click on the column header though and it refreshed and then it worked for the next few patrons I searched for.

Looking at this again, some more notes:

 * The vital_stats method uses open-ils.actor.user.checked_out.count for part of its work. It does include the count of lost times. However, it adds a peer to the open-ils.actor.user.checked_out.count "total" key, called "total_out", that only includes currently "out" (checked out but otherwise in good standing) and overdue, but not long_overdue. "total" includes all open transactions, out, overdue, lost, claims_returned, and long_overdue.
  - HOWEVER: the "total_out" key is ALWAYS overwritten with "out" + "overdue" + "long_overdue", which just adds long_overdue to the server-calculated "total_out" value. Then it checks to see if the circ.do_not_tally_claims_returned and circ.tally_lost YAOUSen are set (which are definitionally inverted ... ugh) and then adds lost and claims_returned based on those.
 * A promise chain following from the vital_stats call checks for noncat circs (via pcrud), and then uses open-ils.actor.usergroup.members.balance_owed.authoritative to gather group fines and totals all of the resulting balances into a fines.group_balance_owed value.
  - It look like this just needs to be displayed in the group.component.html component template.

hrm... I was looking at (and fixing) the Angular version. I will continue with that, but will also address AngJS. It is similarly deficient.

I have a branch that improves both AngJS and Angular versions available here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-1803726-group-member-details