Evergreen

Selfcheck: require password setting is ignored if set to "False"

Bug #1810296 reported by Chris Sharp
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Incomplete
Undecided
Unassigned

Bug Description

If the "Require Patron Password" (circ.selfcheck.patron_password_required) setting for Evergreen's built-in selfcheck is set to "False", the setting is ignored because the setting check in the JavaScript only checks if there is any value. Since "False" is stored as text and not as a boolean value, the setting check always succeeds.

Branch on the way.

Evergreen 3.0 through current master
OpenSRF 3.0.1
PostgreSQL 9.5
Ubuntu 16.04

Revision history for this message
Chris Sharp (chrissharp123) wrote :

This should do the trick:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1810296_selfcheck_require_password_setting

tags: added: pullrequest selfcheck
Revision history for this message
Galen Charlton (gmc) wrote :

Might this be a local issue, Chris? circ.selfcheck.patron_password_required's datatype is bool and I'm seeing nothing in the commit history that indicates that it was ever otherwise in stock Evergreen. As is, your patch breaks the check in master.

tags: added: needsdiscussion
removed: pullrequest
Terran McCanna (tmccanna)
Changed in evergreen:
status: New → Incomplete
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.