carousel required fields

Bug #1851515 reported by Jason Etheridge
24
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Evergreen
Confirmed
Medium
Unassigned

Bug Description

If Owner is not supplied when creating/editing carousels, we get an uncaught DB INSERT error. A similar thing happens with Sequence when linking carousels to libraries.

tags: added: carousel
Changed in evergreen:
status: New → Confirmed
Changed in evergreen:
importance: Undecided → Medium
tags: added: admin-pages opac-carousel
removed: carousel
Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

Confirmed on EG 3.11

Would the correct way to fix this be to mark the

"Sequence Number" field with oils_obj:required="true" of the ccou class in the Fieldmapper?

The Owner field of cc (container.carousel) is already marked as required in the FM though. So maybe the problem is that the eg-org-select doesn't detect setting the required setting?

Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

Updated the eg-org-select thingy so it sets [required], and now it shows green or red hints about being required and not filled in.

I updated the fm_IDL with the required hints for the "ccou" class and that does cause the "Carousels Visible at Library" to have some validation.

But the logic that disables the Save button isn't working fully. Required OU selectors don't prevent the Save button from being enabled. Only the Sequence Number seems to be triggering it on the "Record Editor: Carousels Visible at Library" screen.

The Save button gets disabled if the fmEditForm.invalid is set. Some elements seem not to effect that though.

<button type="button" class="btn btn-info"
      [disabled]="fmEditForm.invalid" *ngIf="mode !== 'view'"
      (click)="save()" i18n>Save</button>

Working branch at: user/stompro/lp1851515_carousel_required_fields

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1851515_carousel_required_fields

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.