allow_phone_notifications would work better as an organizational unit setting

This would be a very helpful setting.

I have pushed a branch to the working repository that makes this change: user/dyrcona/lp1969967-phone-notifications-yaous.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1969967-phone-notifications-yaous

Since there is a change in default behavior of the OPAC, the phone notification options are hidden by default after this patch, I think this should wait until 3.10 at least before it goes into a release. The change in behavior is covered in the release note.

I'm 100% in favor of the change to a library setting. I tested this in the Bootstrap OPAC (did not test in the old OPAC or the KPAC at this time). I confirmed that the org unit setting applies correctly when placing a new hold or when setting default notification preferences under My Account.

However, there are two places where the preference is not applying:

1) My Account > Holds > Edit Hold: When editing an existing hold, it does not hide the "Phone notification - Enter phone number" text or the field to enter the phone number

2) If a phone number is set on a hold (for example, by setting it through the staff client or by editing it) then it appears on the Current Items On Hold page even the option is disabled

And...

3) (This may need a different ticket.) This ticket specifically addresses the public interfaces, BUT I think that if the setting is disabled in the OPAC then it should also be disabled in the staff client. Otherwise, there will inevitably be staff members who are setting phone preferences for patrons that shouldn't have that option and causing a lot of confusion. Some of the places in the staff client that should reflect this:
- Patron registration / edit form
- Place hold page in Angular Staff Catalog
- Edit Notification Settings modal

+1 to addressing the staff client as well. I think this should be a separate bug. For us, we may need two settings so that libraries have the choice of whether or not to disable it in the staff client too.

This is currently mostly used by academic libraries in our consortium. I can imagine potential situations where a library doesn't want phone to be an option in the public catalogue, but still wants staff to be able to set phone notifications for particular patrons or patron groups (ie. maybe faculty can go through staff to get phone notifications).