Due Date Time Not Shown in Staff Catalogue

Just noting as of EG 3.10 there is a new Angular egDueDate filter for addressing these scenarios.

This commit shows how I added the refresh time to the carousel grid:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=blobdiff;f=Open-ILS/src/eg2/src/app/staff/admin/local/admin-carousel.component.html;h=8f8dc6e7b210f883150a4d1a1686b63528eea513;hp=a56294fd43e7987cded2bc60fd3df4154861627c;hb=bee6829c6cd6d35cd2bb6d886152488194373f46;hpb=034bfd31b58e4af60a27d5992437bdba44d97380

Made a commit with the datatype Terran suggested:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=461a5746cee5c93a83734131a718559dc89d1be0

I did test it but not entirely jazzed with the formatting. Attached is a screenshot.

Hmm, it doesn't look to me like the screenshot is reflecting the change. At least, it's not how it formatted the time in the Carousel refresh time column.

I agree that the formatting is not the best, but it's nice to see the time displaying there.

I'm looking at the due date in the catalog and in Item Status on the MOBIUS server for Bug Squashing. The format of the time in the staff catalog is 2023-03-08T23:59:59-0500. The item status screen does not display the time in the view details. Only the date displays.

Hello, I was just trying to test this out also.

The AngularJS interfaces seem to be making use of the library setting "Format Date+Time with this pattern
" if it is set.

Open-ILS/src/templates/staff/cat/item/t_summary_pane.tt2
{{circ.due_date() | egDueDate:egDateAndTimeFormat:circ.circ_lib():circ.duration()}}

If it isn't set then it is just the date in my testing when looking at /eg/ interfaces.

I was trying to change a checkout to being hourly, but I wasn't able to get that to work. No matter what time I set in the change due date interface, it kept forcing it to 11:59pm.

So maybe the issue is that the Angular interfaces need to check the wanted format and use that? Rather than just showing the raw format?

At first I was thinking there was some logic that was saying ( If the hour = 11:59am then only show the date, else show timestamp.) or something like that. Only show the hours when it is significant. But I'm having a hard time confirming that without being able to set the hours in a due date.

Is there a switch to enable hourly checkouts so I can change a due date?

You must setup or use an hourly loan duration in the circulation policy.

I have tested this code and consent to signing off on it with my name, Christine Burns and my email address, <email address hidden>.

Noting upon reviewing this that there's a bit of a mess going on here:

- egDueDate is not currently an option for formatting grid values in rel_3_10. It expects to be passed a whole circ IDL object, which is not currently available in to the Angular item table. Also, there's some code that looks like this that cannot work at present:

src/app/staff/circ/patron/billing-history.component.html: label="Due Date" datefilter="egDueDate" [hidden]="true"></eg-grid-column>

The problem? The Angular grid has no notion of a datefilter attribute; only the AngularJS grid does.

- Now, the Angular eg-grid *does* have a way to get at a similar effect: use the timezoneContextOrg and dateOnlyIntervalField attributes of eg-grid-column. However, changes to open-ils.search.bib.copies.staff would be needed to supply the _loan_'s circ_lib and duration values.

So, marking this as "needswork". I'll make a stab at sorting this out.