opportunistic capture can fail to find relevant holds

Bug #2004520 reported by Galen Charlton
94
This bug affects 19 people
Affects Status Importance Assigned to Milestone
Evergreen
New
Undecided
Unassigned

Bug Description

The list of potential holds that an item might fill returned by open-ils.storage.action.hold_request.nearest_hold can contain duplicates entries. The duplicates occur for each non-blocking standing penalty after the first for the patron associated with a candidate hold - and the notes consolidation change likely means that there are more of them.

As a consequence, opportunistic hold capture can end up doing redundant hold permit tests, thereby wasting some of the up to 100 candidate holds returned by the nearest_hold method. Empirically, this has resulted in opportunistic hold capture failing to target holds that could have been filled (for a really popular title).

Evergreen 3.9

Tags: circ-holds
Galen Charlton (gmc)
tags: added: circ-holds
Revision history for this message
Galen Charlton (gmc) wrote :

An initial patch for feedback is available in the user/gmcharlt/lp2004520_dedupe_nearest_hold-wip working branch.

Revision history for this message
Terran McCanna (tmccanna) wrote :

Adding pullrequest tag in hopes that this will get more eyes on it for testing

tags: added: pullrequest
Revision history for this message
Galen Charlton (gmc) wrote :

We're working on a reworked version of the patch, so while more eyes are always appreciated for the concept, the current WIP should _not_ be merged.

Revision history for this message
Chris Sharp (chrissharp123) wrote :

Removing pullrequest tag per Galen's comment.

tags: removed: pullrequest
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.