Default FavIcon should be RSS-icon

Bug #1313019 reported by ITPROJECTS
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Feedler
Fix Committed
Undecided
Cleiton Floss

Bug Description

The default icon makes it look as if the RSS feed isnt working, when it is. It would be better to change it to the one used for Feedler. desktop icon. This way th UI looks better and is more fitting.

Proposed (rough) visual change:

http://s29.postimg.org/k6bcxz50j/image.png

Related branches

Revision history for this message
ITPROJECTS (itprojects) wrote :

It seems that was actually a BUG. Here is the one-line-patch.

Revision history for this message
ITPROJECTS (itprojects) wrote :

Here is the fixed-bug final image.

http://s29.postimg.org/ysrovc9wn/image.png

Revision history for this message
Nicolai Tassani (nicolai-c) wrote :

Hi! How to we can apply "the patch". Thanks!

Revision history for this message
ITPROJECTS (itprojects) wrote :

The easiest way is to just change "pnh" to "png" in the line where:

("favicon", "pnh")));

should be:

 ("favicon", "png")));

THERE IS NO PNH !!!

Revision history for this message
Nicolai Tassani (nicolai-c) wrote :

Thanks for your time and the fast response! I can stand, but where i can do this change?

Revision history for this message
ITPROJECTS (itprojects) wrote :

The general way of changing a package is:

1. Install the development tools

usually:

sudo apt-get install bzr

sudo apt-get install build-essential

2. Download the source package from repository

3. Change the file in question

4. Build the new source code package

5. Upload the package to launchpad.net

6. Hope that they accept your changes.

Revision history for this message
Nicolai Tassani (nicolai-c) wrote :

Well, i can do it. Thanks for the information! My unique new consult is:
I upload the resutl to "my launchpad" or what? Really thanks for all your help ;)

Revision history for this message
ITPROJECTS (itprojects) wrote :

Yes, you upload to your launchpad, where you'll have made a copy of feedler first. Then you add your changes. Then you ask the Feedler administrator to see your changed feedler. *IF* they like it you have a version. *IF* they don't . . .

Revision history for this message
Nicolai Tassani (nicolai-c) wrote :

Perfect! I stand. Now i encountred new "issues". Firtst my system dont has vala executable, but i resolve it.
And now... i get that, you can help me?
nicolai@nicolai-SATELLITE-L845:~/feedler/build$ cmake .. -DCMAKE_INSTALL_PREFIX=/usr
-- checking for modules 'webkitgtk-3.0;gtk+-3.0;sqlheavy-0.1;libsoup-2.4;libxml-2.0;libnotify;unity;granite;indicate-0.7'
-- package 'webkitgtk-3.0' not found
-- package 'gtk+-3.0' not found
-- package 'sqlheavy-0.1' not found
-- package 'libsoup-2.4' not found
-- package 'libxml-2.0' not found
-- package 'libnotify' not found
-- package 'unity' not found
-- package 'granite' not found
-- package 'indicate-0.7' not found
CMake Error at /usr/share/cmake-2.8/Modules/FindPkgConfig.cmake:266 (message):
  A required package was not found
Call Stack (most recent call first):
  /usr/share/cmake-2.8/Modules/FindPkgConfig.cmake:320 (_pkg_check_modules_internal)
  CMakeLists.txt:43 (pkg_check_modules)

-- checking for a minimum Vala version of 0.16.0
-- found Vala, version 0.26.2
-- checking for modules 'libsoup-2.4;libxml-2.0;libnotify;granite'
-- package 'libsoup-2.4' not found
-- package 'libxml-2.0' not found
-- package 'libnotify' not found
-- package 'granite' not found
CMake Error at /usr/share/cmake-2.8/Modules/FindPkgConfig.cmake:266 (message):
  A required package was not found
Call Stack (most recent call first):
  /usr/share/cmake-2.8/Modules/FindPkgConfig.cmake:320 (_pkg_check_modules_internal)
  src/service/CMakeLists.txt:5 (pkg_check_modules)

-- checking for a minimum Vala version of 0.14.2
-- found Vala, version 0.26.2
-- GSettings schemas will be installed locally.
-- GSettings shemas will be compiled.
-- GSettings schemas will be installed into /usr/share/glib-2.0/schemas/
-- Configuring incomplete, errors occurred!

Revision history for this message
Nicolai Tassani (nicolai-c) wrote :

Well, now i can stand again. I dont want install Unity for resolve the favicons issue. Its so much only for this little bug. Thanks anyway.

Revision history for this message
Nicolai Tassani (nicolai-c) wrote :

Well... libunity is not unity :)
But, what is that?
nicolai@nicolai-SATELLITE-L845:~/feedler/build$ make
[ 1%] Generating src/desktop-launcher.c, src/database.c, src/dock.c, src/feedler.c, src/icons.c, src/indicator.c, src/history.c, src/manager.c, src/settings.c, src/window.c, src/ui/contractor.c, src/ui/folder.c, src/ui/infobar.c, src/ui/layout.c, src/ui/menu.c, src/ui/preferences.c, src/ui/sidebar.c, src/ui/sidebar-cell.c, src/ui/statusbar.c, src/ui/subscription.c, src/ui/toolbar.c, src/ui/view.c, src/ui/view-cell.c, src/ui/view-list.c, src/ui/view-web.c, src/service/interface.c, src/service/model.c, src/service/serializer.c
error: Package `DbusmenuGtk3-0.4' not found in specified Vala API directories or GObject-Introspection GIR directories
Compilation failed: 1 error(s), 0 warning(s)
make[2]: *** [src/desktop-launcher.c] Error 1
make[1]: *** [CMakeFiles/feedler.dir/all] Error 2
make: *** [all] Error 2

Revision history for this message
ITPROJECTS (itprojects) wrote :

Try something like:

sudo apt-get build-dep feedler

More information here:

https://www.debian.org/doc/manuals/apt-howto/ch-sourcehandling.en.html

You shouldn't need unity for this program.

Revision history for this message
Nicolai Tassani (nicolai-c) wrote :

Excellent my friend ITPROJECTS (itprojects)!!!
I finally do it! But how i can share the result with the others? How i can upload my "bzr push lp:~nicolai-c/feedler/feedler".
Thanks for all your help.

Revision history for this message
Nicolai Tassani (nicolai-c) wrote :

Uploading i get thats errors:

nicolai@nicolai-SATELLITE-L845:~$ bzr push lp:~nicolai-c/feedler/feedler
bzr: ERROR: No es una rama: «/home/nicolai/».

nicolai@nicolai-SATELLITE-L845:~$ bzr push lp:~nicolai-c/+junk/feedler
bzr: ERROR: No es una rama: «/home/nicolai/».

I already have my ssh key working...

Revision history for this message
ITPROJECTS (itprojects) wrote :

I am not sure what the error means. This repository was registered by https://launchpad.net/~aroman, get in touch with them. Email them the changes, using a sharing website. Maybe they'll know what to do...

Revision history for this message
Nicolai Tassani (nicolai-c) wrote :

Ok my friend, with all your help i can solve my "problem" and now im sharing the result here https://code.launchpad.net/~nicolai-c/+junk/feedler
I really appreciate this. I learned a lot with your help!
I will contact aroman. Thanks agaian ;)

Changed in feedler:
assignee: nobody → Cleiton Floss (cleitonfloss)
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Patches

Remote bug watches

Bug watches keep track of this bug in other bug trackers.