[facebook] add optional argument to send for type (image, link, video)
Bug #1170559 reported by
Ken VanDine
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Friends |
Triaged
|
Undecided
|
Unassigned | ||
Bug Description
When posting to facebook, we should allow the API to pass in an optional type argument that gets passed along to the facebook API by setting type=type in the send request to facebook. This ensures facebook displays the post online appropriately. For example, if you are sharing a link friends would pass type=link in the request and facebook would display it as a shared link in the news feed (including nice preview of the site.
| Changed in friends: | |
| status: | New → Triaged |
| assignee: | nobody → Robert Bruce Park (robru) |
Revision history for this message
| Robert Bruce Park (robru) wrote | #1 |
| Changed in friends: | |
| assignee: | Robert Bruce Park (robru) → nobody |
To post a comment you must log in.
Agreed, but I don't want to hardcode any random options into the friends api, because there'll always be some new thing that we'll need to add and we'll never achieve decent api stability.
What we really need to do is come up with a way to pass in arbitrary key value pairs directly from the qml through libfriends and into the friends operations. Most likely this would need to be serialized as a string in order to pass through dbus with minimum hassle, so we should consider something like either json or urlencoding (both are already used in friends so there no extra overhead, really just a matter of style)
The upshot of this is that if we do allow arbitrary key value pairs to be passed through, then we'll be able to simplify and unify the dbus api (it will become possible to invoke all methods just with dispatcher.Do(). Simplifying the api will reduce maintenance burden, because it'll be much more flexible, not requiring any modifications in order to support new features in the future.