adding a node to a cluster with a admin IP that is foreign admin network internals returns 500 and ejects node from from the nodes list
2014-01-21 06:39:04.671 DEBUG [7ff73ebfd700] (logger) Request PUT /api/v1/nodes/
from 127.0.0.1:45760 [{"pending_addition": true, "pending_roles": ["controller"
], "cluster_id": "1", "id": 4, "pending_deletion": false}]
2014-01-21 06:39:04.731 ERROR [7ff73ebfd700] (logger) Traceback (most recent cal
l last):
File "/opt/nailgun/lib/python2.6/site-packages/web/application.py", line 239,
in process
return self.handle()
File "/opt/nailgun/lib/python2.6/site-packages/web/application.py", line 230,
in handle
return self._delegate(fn, self.fvars, args)
File "/opt/nailgun/lib/python2.6/site-packages/web/application.py", line 420,
in _delegate
return handle_class(cls)
File "/opt/nailgun/lib/python2.6/site-packages/web/application.py", line 396,
in handle_class
return tocall(*args)
File "<string>", line 2, in PUT
File "/opt/nailgun/lib/python2.6/site-packages/nailgun/api/handlers/base.py",
line 55, in content_json
data = func(*args, **kwargs)
File "/opt/nailgun/lib/python2.6/site-packages/nailgun/api/handlers/node.py", line 438, in PUT
network_manager.assign_networks_by_default(node)
File "/opt/nailgun/lib/python2.6/site-packages/nailgun/network/neutron.py", line 127, in assign_networks_by_default
ifaces = [node.admin_interface]
File "/opt/nailgun/lib/python2.6/site-packages/nailgun/db/sqlalchemy/models/node.py", line 228, in admin_interface
return self.interfaces[0]
IndexError: list index out of range
2014-01-21 06:39:04.732 ERROR [7ff73ebfd700] (logger) Response code '500 Internal Server Error' for PUT /api/v1/nodes/ from 127.0.0.1:45760
We found that the actual issue is that during the agent update, it would remove all of the interfaces from the host because no interface in the list was tagged as the admin interface.
To fix this, we will add the same fall-back method that the agent uses. If a suitable interface isn't found, we will match the mac that matched the system interface (the one that contacted fuel in the first place) and use that one.