Broken processing of 'skipped' status for tests

Bug #1282106 reported by Artem Roma
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Artem Roma

Bug Description

Info about environment:
- release - 4.1
- fuel-ostf commit sha - "f86abe5544b5ffcf621e0c450bca15737c92361f"

Description:
Tests can have status "skipped" which is assigned to them if test run was skipped by rising SkipTest exception that is processed in our custom plugin for nose via type comparison. Mentioned exception can be raised either via calling method skipTest of TestCase class (of unittest or unittest2 modules) or by directly raise unittest2.SkipTest.

And the problem is that type comparison in addError hook of nose plugin is not triggered in second variant which leads to tests having 'error' status instead of 'skipped'.

Additional info:
One can test this bug on test environment for ostf-adapter by launching its functional tests.

Tags: ostf-adapter
Artem Roma (aroma-x)
Changed in fuel:
status: New → In Progress
Mike Scherbakov (mihgen)
Changed in fuel:
milestone: 4.1 → 5.0
Artem Roma (aroma-x)
Changed in fuel:
status: In Progress → Confirmed
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to fuel-ostf (master)

Fix proposed to branch: master
Review: https://review.openstack.org/89636

Changed in fuel:
status: Confirmed → In Progress
Changed in fuel:
milestone: 5.0 → 5.1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-ostf (master)

Reviewed: https://review.openstack.org/89636
Committed: https://git.openstack.org/cgit/stackforge/fuel-ostf/commit/?id=138be75771946488c642ec3c49a823ef8294d4b6
Submitter: Jenkins
Branch: master

commit 138be75771946488c642ec3c49a823ef8294d4b6
Author: Artem Roma <email address hidden>
Date: Tue Apr 22 19:32:32 2014 +0300

    Proper skip action processing added

    Now skipped tests are processing properly via NoseStoragPlugin.

    Change-Id: I6e70ef9d11aeed7c55c0a5dd96adf417c16116c7
    Closes-Bug: #1282106

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.