Fuel for OpenStack

Need 'deeper' merge_behavior in Hiera

Bug #1462528 reported by Aleksandr Didenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Alex Schultz
Fuel for OpenStack 7.0
6.1.x
Invalid
High
Fuel build team
Fuel for OpenStack 6.1-updates
7.0.x
Fix Released
High
Alex Schultz
Fuel for OpenStack 7.0

Bug Description

We should use 'deeper' merge_behavior in Hiera in order to provide proper overriding mechanism in Hiera which is needed, for instance, for service detachment blue-print.

So we need:
1) to install https://apt.puppetlabs.com/pool/precise/dependencies/r/ruby-deep-merge/ruby-deep-merge_1.0.0-1puppetlabs1_all.deb package
2) update /etc/hiera.yaml settings with:
:merge_behavior: deeper

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/188921

Changed in fuel:
status: New → In Progress
Revision history for this message
Aleksandr Didenko (adidenko) wrote :

We have prepared a patch for fuel-library, now we need ruby-deep-merge packages for this to work.

Changed in fuel:
assignee: Aleksandr Didenko (adidenko) → Fuel OSCI Team (fuel-osci)
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Related fix proposed to packages/trusty/ruby-hiera (7.0)

Related fix proposed to branch: 7.0
Change author: Aleksandr Mogylchenko <email address hidden>
Review: https://review.fuel-infra.org/8876

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Related fix merged to packages/trusty/ruby-hiera (7.0)

Reviewed: https://review.fuel-infra.org/8876
Submitter: Michael Semenov <email address hidden>
Branch: 7.0

Commit: 2dd8dbb4414687756ea9e71a1732231dfe15b504
Author: Aleksandr Mogylchenko <email address hidden>
Date: Tue Jun 30 12:39:57 2015

Add 'Recommends:' field on ruby-deep-merge for Hiera.

Ruby-deep-merge allows using ':merge_behavior: deeper' in Hiera, and field
solves the problem with dependencies.

Related-Bug: #1464766
Related-Bug: #1462528
Change-Id: I0d1000fc853ce4be58b188cb9d3ebb588d7826f7

OpenStack Infra (hudson-openstack)
Changed in fuel:
assignee: Fuel OSCI Team (fuel-osci) → Aleksandr Didenko (adidenko)
status: Confirmed → In Progress
OpenStack Infra (hudson-openstack)
Changed in fuel:
assignee: Aleksandr Didenko (adidenko) → Alex Schultz (alex-schultz)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/188921
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=ba6a60fa094bd73098b98f9a81ad961d0c2481bd
Submitter: Jenkins
Branch: master

commit ba6a60fa094bd73098b98f9a81ad961d0c2481bd
Author: Aleksandr Didenko <email address hidden>
Date: Fri Jun 5 16:04:54 2015 -0500

    Set :merge_behavior: to deeper for Hiera

    We should use 'deeper' merge_behavior in Hiera in order to provide
    proper overriding mechanism in Hiera.

    Partial blueprint: detach-components-from-controllers
    Partial-bug: #1462528

    Change-Id: I66f71c5c65b1db7bb3b6eb2d1bc72be91a09fd44

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-main (master)

Reviewed: https://review.openstack.org/193639
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=5f4303958f07a51eb6ce52ecf796fa4a8152490f
Submitter: Jenkins
Branch: master

commit 5f4303958f07a51eb6ce52ecf796fa4a8152490f
Author: Alex Schultz <email address hidden>
Date: Fri Jun 19 11:57:46 2015 -0500

    Add ruby-deep-merge to requirements

    In order to support the 'deeper' merge behavior in hiera, we need the
    deep_merge gem available to puppet. This is required to allow for
    overriding our heira.

    Change-Id: I8e72af25db29d558b7fcd30be7ee7de3e581aecc
    Related-Bug: 1462528
    Related-Bug: 1464766

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-library (master)

Change abandoned by Alex Schultz (<email address hidden>) on branch: master
Review: https://review.openstack.org/193636
Reason: this won't solve the issue as we don't need to install it on the fuel master, need a different method to target only the non-fuel master nodes

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-library (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/204769

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/204769
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=8e8a2af711dc0304aaf90b4a4589de8750d46196
Submitter: Jenkins
Branch: master

commit 8e8a2af711dc0304aaf90b4a4589de8750d46196
Author: Alex Schultz <email address hidden>
Date: Wed Jul 22 16:23:37 2015 -0500

    Install rubygem-deep_merge as part of hiera task

    This change adds the installation of the deep_merge package as part of
    the hiera configuration to enable the deeper merge behaviour.

    Change-Id: I62dd9f612e1533d0406affa5d1a820680ba2a509
    Related-Bug: 1462528
    Related-Bug: 1464766

Revision history for this message
Vladimir Khlyunev (vkhlyunev) wrote :

ISO 287 - verified due to working separate-service feature

Revision history for this message
Denis Meltsaykin (dmeltsaykin) wrote :

This doesn't look like an issue. Closing this as Invalid for 6.1 as the impact is unclear.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.