UX Fuel behavior became unexpected after applying logging patch from 199026/1 review

Bug #1489830 reported by Denis Klepikov
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Invalid
High
Roman Rufanov
6.1.x
Invalid
High
MOS Maintenance

Bug Description

Fuel behavior became unexpected after applying patch from 199026/1 review

[root@fuel ~]# cat /etc/fuel/version.yaml
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "6.0"
  api: "1.0"
  build_number: "58"
  build_id: "2014-12-26_14-25-46"
  astute_sha: "16b252d93be6aaa73030b8100cf8c5ca6a970a91"
  fuellib_sha: "fde8ba5e11a1acaf819d402c645c731af450aff0"
  ostf_sha: "a9afb68710d809570460c29d6c3293219d3624d4"
  nailgun_sha: "5f91157daa6798ff522ca9f6d34e7e135f150a90"
  fuelmain_sha: "81d38d6f2903b5a8b4bee79ca45a54b76c1361b8"

How to reproduce:
1. Apply patch from https://review.openstack.org/#/c/199026/1
2. Try to deploy cluster using this schema:

nodes config: non-ha, Ubuntu, neutron+vlan
 1 controller
 1 compute
 1 compute+ceph-osd
 1 ceph-osd
 1 mongo

ceph for cinder, glance default public IP on all nodes, debug enabled.

networks on controller node are not configured during deployment, deployment fails

What was found:
https://review.openstack.org/#/c/199026/1
deployment/puppet/anacron/files/logrotate-debug nulled, but

deployment/puppet/anacron/manifests/config.pp
lines 40-44 still point us to unexisting file

Changed in fuel:
assignee: nobody → Fuel Library Team (fuel-library)
importance: Undecided → High
Changed in fuel:
milestone: none → 6.0-updates
Revision history for this message
Denis Klepikov (dklepikov) wrote :

High due to Customer awaiting for patch "Polish logrotate configuration"

tags: added: logging
Revision history for this message
Bartłomiej Piotrowski (bpiotrowski) wrote :

The fact that anacron/config.pp points to not-existent file is irrelevant. The reason of failure is that the path hasn't been applied to /etc/puppet/manifests/site.pp. Doing so manually fixes the problem.

summary: - Fuel behavior became unexpected after applying patch from 199026/1
- review
+ UX Fuel behavior became unexpected after applying logging patch from
+ 199026/1 review
Revision history for this message
Bartłomiej Piotrowski (bpiotrowski) wrote :

Following patch makes the deployment pass, to be applied on the master node: http://paste.openstack.org/show/430788/

Changed in fuel:
assignee: Fuel Library Team (fuel-library) → Bartlomiej Piotrowski (bpiotrowski)
Revision history for this message
Bartłomiej Piotrowski (bpiotrowski) wrote :

Anyway, there is nothing to be done about this from Library Team side. Maintenance team, is the patch correctly applied by upgrade packs?

Changed in fuel:
assignee: Bartlomiej Piotrowski (bpiotrowski) → MOS Maintenance (mos-maintenance)
Revision history for this message
Bartłomiej Piotrowski (bpiotrowski) wrote :

Actually missing logrotate-debug is even less important, because anacron class isn't used anywhere.

Revision history for this message
Denis Klepikov (dklepikov) wrote :

Please provide an additional patch, that must be applied after 199026/1 on vanilla 6.0 fuel to fully resolve an issue, including removing logrotate-debug

Revision history for this message
Bartłomiej Piotrowski (bpiotrowski) wrote :

See #3. As I already said, we don't apply anacron class, so this is dead code.

Revision history for this message
Denis Klepikov (dklepikov) wrote :

applied patch https://review.openstack.org/#/c/199026/1 and patch you provide http://paste.openstack.org/show/430788/

nodes config: non-ha, Ubuntu, neutron+vlan
 1 controller
 1 compute
 1 compute+ceph-osd
 1 ceph-osd
 1 mongo

ceph for cinder, glance default public IP on all nodes, debug enabled.

Deploy failes

 Duplicate declaration: Nova_config[libvirt/inject_partition] is already declared in file /etc/puppet/modules/ceph/manifests/ephemeral.pp:13; cannot redeclare at /etc/puppet/modules/openstack/manifests/compute.pp:315 on node node-14.domain.tld

Revision history for this message
Vitaly Sedelnik (vsedelnik) wrote :

The is no way to deliver fuel-library fixes in 6.0 maintenance updates because fuel library is not packaged in 6.0. Setting it to Won't Fix.

Changed in fuel:
status: New → Won't Fix
Revision history for this message
Andrew Woodward (xarses) wrote :

Customer found in 6.0

Figure out a way to provide update to affected users. At a minimum provide a patch and proper directions to apply it in this ticket

Changed in fuel:
status: Won't Fix → Confirmed
no longer affects: fuel/6.0.1-updates
Roman Rufanov (rrufanov)
tags: added: customer-found support
Changed in fuel:
milestone: 6.0-updates → 6.0.1
Revision history for this message
Roman Rufanov (rrufanov) wrote :

another customer run into same issue - please fix for 6.0 and 6.1

Changed in fuel:
milestone: 6.0-updates → 6.0-mu-7
assignee: MOS Maintenance (mos-maintenance) → Denis Meltsaykin (dmeltsaykin)
Revision history for this message
Denis Meltsaykin (dmeltsaykin) wrote :

You say the customer has applied the untested patch-set from the CR that didn't make it into 6.0-GA, right? And what part of this "bug" is customer-found? This is quiet predictable, if one applies some untested things one would run into problems. How should we fix it?

Changed in fuel:
assignee: Denis Meltsaykin (dmeltsaykin) → Roman Rufanov (rrufanov)
Revision history for this message
Denis Meltsaykin (dmeltsaykin) wrote :

As it was previously said, we have very limited ability to deliver the fuel-library fixes in 6.0. Moreover, current stable/6.0 branch is not backwards comptaible with the existing Fuel 6.0GA, so you cannot just take a patch from there and use it in your 6.0GA.
You can use this patch on your own risk making sure you didn't fetch all the linked commits from gerrit (problem in comment #8 looks very similar to that), resolving code conflicts and manually changing your /etc/puppet/manifests/site.pp, as it's not the part of patch. But anyway this will fix only *newly* added nodes, the existing ones will have the old configuration, which you should fix manually.

Revision history for this message
Denis Meltsaykin (dmeltsaykin) wrote :

The original patch is a backport from 6.1, so setting as Invalid for 6.1 as it already contains the fix.

Revision history for this message
Vitaly Sedelnik (vsedelnik) wrote :

This is not a product issue but some issue occured after applying patch. This is patch issue, not MOS 6.0 one - Invalid for 6.0-updates

Changed in fuel:
milestone: 6.0-mu-7 → 6.0-updates
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.