Fuel for OpenStack

fuel-agent has generic names for files in /usr/bin

Bug #1541873 reported by Thomas Goirand
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Confirmed
Medium
Artem Silenkov
Fuel for OpenStack 10.0
Mitaka
Won't Fix
Medium
Artem Silenkov
Fuel for OpenStack 9.0
Newton
Confirmed
Medium
Artem Silenkov
Fuel for OpenStack 10.0

Bug Description

The file in contrib/fuel_bootstrap/files/trusty/usr/bin/send2syslog.py isn't matching the Debian policy, which is no script in /usr/bin should include the shell script extension. Also, "send2syslog" is too generic. In the Debian package, I used:

/usr/bin/fa_send2syslog

Please rename it the same way upstream.

The same way, we have contrib/fuel_bootstrap/files/trusty/usr/bin/fix-configs-on-startup. In Debian, I renamed it as:

/usr/bin/fa_fix-configs-on-startup

Finally, in the main python code of fuel-agent, we have /usr/bin/provision. Please rename it as:

/usr/bin/fa_provision

I am well aware that what I have produced in Debian may not work (yet) because of these filename changes, as I did fix the internal code of fuel-agent about a year ago as a Debian patch. It is my hope though, that this will be fixed upstream the way I am suggesting.

Revision history for this message
Thomas Goirand (thomas-goirand) wrote :

Ah, now I remember! :)

So, only fix-configs-on-startup references send2syslog.py, so it's easy to fix. Then, instead of writing an rc.local (boooooo... ugly...), I just wrote an init script which calls /usr/bin/fa_fix-configs-on-startup. This has the same effect, but it can be packaged in a Debian policy compliant way.

Many files under contrib/fuel_bootstrap/files/trusty/etc are hardly package-able by the way. For example, contrib/fuel_bootstrap/files/trusty/etc/hostname can't be done this way. Instead, the hostname shall be fixed when preparing the image. Files like contrib/fuel_bootstrap/files/trusty/etc/modules belong to other packages (kmod in this case) and can't be replaced in this way.

So, just installing fuel-agent wont be enough for preparing the image, which is a shame. We should find some better way than just dropping files from contrib/fuel_bootstrap/files/trusty in the bootstrap image. Suggestions welcome.

Revision history for this message
Ihor Kalnytskyi (ikalnytskyi) wrote :

Why do we need this terrible script at the first place?

Matthew Mosesohn (raytrac3r)
Changed in fuel:
milestone: none → 9.0
assignee: nobody → Fuel build team (fuel-build)
importance: Undecided → Medium
status: New → Confirmed
tags: added: area-build bootstrap
Revision history for this message
Roman Vyalov (r0mikiam) wrote :

reassign to mos-packaging team, because it is their responsibility

Changed in fuel:
assignee: Fuel build team (fuel-build) → MOS Packaging Team (mos-packaging)
status: Confirmed → New
tags: removed: area-build
Artem Silenkov (asilenkov)
Changed in fuel:
assignee: MOS Packaging Team (mos-packaging) → Artem Silenkov (asilenkov)
Roman Podoliaka (rpodolyaka)
Changed in fuel:
status: New → Confirmed
tags: added: area-packaging
Revision history for this message
Thomas Goirand (thomas-goirand) wrote :

Igor, we mostly need "this terrible script" (I agree it's really ugly) in the bootstrap image, so we can have /etc/mcollective/server.cfg to be setup with the write hostname for the rabbitmq connection, depending on the url= parameter on the kernel command line.

Revision history for this message
Bug Checker Bot (bug-checker) wrote : Autochecker

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

actual result

version

expected result

steps to reproduce

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

tags: added: need-info
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.