Fuel for OpenStack

udevadm doesn't have a --quiet option anymore in Debian Jessie and up

Bug #1552349 reported by Thomas Goirand
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Anil Shashikumar Belur
Fuel for OpenStack 9.0
8.0.x
Fix Released
High
Anton Chevychalov
Fuel for OpenStack 8.0-mu-4

Bug Description

fuel-agent is using the --quiet option of udevadm, which doesn't exist anymore, resulting in a full breakage in Jessie, and a warning in Sid. This probably will also break in Ubuntu Xenial.

Here's the output in Sid:
# udevadm settle --quiet
Option -q no longer supported.

And here's the patch I applied in Debian:

--- fuel-agent-7.0+2016.01.29.git.99dc8a2be7+dfsg1.orig/fuel_agent/utils/utils.py
+++ fuel-agent-7.0+2016.01.29.git.99dc8a2be7+dfsg1/fuel_agent/utils/utils.py
@@ -364,7 +364,7 @@ def unblacklist_udev_rules(udev_rules_di

 def udevadm_settle():
- execute('udevadm', 'settle', '--quiet', check_exit_code=[0])
+ execute('udevadm', 'settle', check_exit_code=[0])

 def parse_kernel_cmdline():
--- fuel-agent-7.0+2016.01.29.git.99dc8a2be7+dfsg1.orig/fuel_agent/tests/test_utils.py
+++ fuel-agent-7.0+2016.01.29.git.99dc8a2be7+dfsg1/fuel_agent/tests/test_utils.py
@@ -289,7 +289,7 @@ class ExecuteTestCase(unittest2.TestCase
     @mock.patch.object(utils, 'execute')
     def test_udevadm_settle(self, mock_exec):
         utils.udevadm_settle()
- mock_exec.assert_called_once_with('udevadm', 'settle', '--quiet',
+ mock_exec.assert_called_once_with('udevadm', 'settle',
                                           check_exit_code=[0])

Alexander Kislitsky (akislitsky)
tags: added: area-python
Changed in fuel:
importance: Undecided → High
milestone: none → 9.0
assignee: nobody → Fuel Python Team (fuel-python)
status: New → Confirmed
Revision history for this message
Dmitry Pyzhov (dpyzhov) wrote :

Doesn't affect current use cases. Marking as tech-debt. Leaving as high priority because it definitely will cause issues in the future.

tags: added: tech-debt
Revision history for this message
Thomas Goirand (thomas-goirand) wrote :

Dmitry, I'm using Fuel on Debian right now, so I am really affected right now, it's a current use case. Unless there's a strong message from the management that I should stop my work on this, please do consider there's a use case.

Alexander Gordeev (a-gordeev)
tags: added: low-hanging-fruit
Dmitry Pyzhov (dpyzhov)
tags: added: feature-image-based
Revision history for this message
Anil Shashikumar Belur (askb23) wrote :

Hi, I would like to help on this issue, If no one else if presently working on this.

Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Anil Shashikumar Belur (askb23)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-agent (master)

Fix proposed to branch: master
Review: https://review.openstack.org/294218

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-agent (master)

Reviewed: https://review.openstack.org/294218
Committed: https://git.openstack.org/cgit/openstack/fuel-agent/commit/?id=08a3e89150008ef3d32101bea31c0d2f03f6907a
Submitter: Jenkins
Branch: master

commit 08a3e89150008ef3d32101bea31c0d2f03f6907a
Author: Anil Belur <email address hidden>
Date: Thu Mar 17 23:36:44 2016 +0530

    Fixes bug #1552349 - udevadm doesn't have a --quiet

    This fixes a deprecated option with`udevadm`, the `--quiet` option
    is removed in Debian (Jessie and later release), therefore removing the
    option from the code as suggested in patch.

    Closes-bug: #1552349
    Change-Id: Ia9ff7b1b40681ee0f647949ae9617c87adb41231
    Signed-off-by: Anil Belur <email address hidden>

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Anton Chevychalov (achevychalov) wrote :

That also affect CentOS bootstrap image from MOS 8.0.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-agent (stable/8.0)

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/373142

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-agent (stable/8.0)

Reviewed: https://review.openstack.org/373142
Committed: https://git.openstack.org/cgit/openstack/fuel-agent/commit/?id=2e98d2ed5fdfcb79428e2f12a296d5cf68dc82b5
Submitter: Jenkins
Branch: stable/8.0

commit 2e98d2ed5fdfcb79428e2f12a296d5cf68dc82b5
Author: Anil Belur <email address hidden>
Date: Thu Mar 17 23:36:44 2016 +0530

    Fixes bug #1552349 - udevadm doesn't have a --quiet

    This fixes a deprecated option with`udevadm`, the `--quiet` option
    is removed in Debian (Jessie and later release), therefore removing the
    option from the code as suggested in patch.

    Closes-bug: #1552349
    Change-Id: Ia9ff7b1b40681ee0f647949ae9617c87adb41231
    Signed-off-by: Anil Belur <email address hidden>
    (cherry picked from commit 08a3e89150008ef3d32101bea31c0d2f03f6907a)

Revision history for this message
Ekaterina Shutova (eshutova) wrote :

Verified on 8.0 + mu4 updates.
Before:
[root@nailgun ~]# udevadm settle --quiet
[root@nailgun ~]# udevadm settle -h
Usage: udevadm settle OPTIONS
  --timeout=<seconds> maximum time to wait for events
  --seq-start=<seqnum> first seqnum to wait for
  --seq-end=<seqnum> last seqnum to wait for
  --exit-if-exists=<file> stop waiting if file exists
  --quiet do not print list after timeout
  --help
After:
[root@nailgun ~]# udevadm settle --quiet
Option -q no longer supported.
[root@nailgun ~]# udevadm settle -h
udevadm settle OPTIONS

Wait for pending udev events.

  -h --help Show this help
     --version Show package version
  -t --timeout=SECONDS Maximum time to wait for events
  -E --exit-if-exists=FILE Stop waiting if file exists

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.