Alien "/etc/fuel/bootstrap_admin_node.confe" file on Fuel Master

Bug #1553154 reported by Dmitry Burmistrov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Low
Sergey Kulanov

Bug Description

After installation I have 2 files:
[root@fuel ~]# ls -l /etc/fuel/bootstrap_admin_node.conf*
-rw-r--r--. 1 root root 129 Mar 3 13:57 /etc/fuel/bootstrap_admin_node.conf
-rw-r--r--. 1 root root 125 Mar 3 13:49 /etc/fuel/bootstrap_admin_node.confe
[root@fuel ~]#

Here is the diff:
[root@fuel ~]# diff -u /etc/fuel/bootstrap_admin_node.conf{,e}
--- /etc/fuel/bootstrap_admin_node.conf 2016-03-03 13:57:58.979000000 +0000
+++ /etc/fuel/bootstrap_admin_node.confe 2016-03-03 13:49:12.109639450 +0000
@@ -1,5 +1,5 @@
 #Set to yes to run Fuel Setup
 #Set to no to accept default settings
-ADMIN_INTERFACE=eth0
+ADMIN_INTERFACE=
 showmenu=no
 wait_for_external_config=no
[root@fuel ~]#

So "e"-file was modified earlier.

Maybe there is a typo in a code.

my ISO: fuel-9.0-mitaka-64-2016-03-03_12-16-00.iso

Tags: area-build
Changed in fuel:
importance: Undecided → Medium
assignee: nobody → Fuel build team (fuel-build)
status: New → Confirmed
milestone: none → 9.0
tags: added: area-build
Changed in fuel:
assignee: Fuel build team (fuel-build) → Sergey Kulanov (skulanov)
status: Confirmed → In Progress
Revision history for this message
Sergey Kulanov (skulanov) wrote :

This happened because of sed -ie usage:

       -i[SUFFIX], --in-place[=SUFFIX]

              edit files in place (makes backup if SUFFIX supplied)

we can remove `-e`

Changed in fuel:
importance: Medium → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-main (master)

Fix proposed to branch: master
Review: https://review.openstack.org/288445

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-main (master)

Reviewed: https://review.openstack.org/288445
Committed: https://git.openstack.org/cgit/openstack/fuel-main/commit/?id=9f816d2a366ee703f7b435cd1c34dd2c29a7b573
Submitter: Jenkins
Branch: master

commit 9f816d2a366ee703f7b435cd1c34dd2c29a7b573
Author: Sergey Kulanov <email address hidden>
Date: Fri Mar 4 14:59:25 2016 +0200

    Fix sed -i flag usage

    We don't need to create any backup with e SUFFIX so let's just
    remove -e flag since:
            the first non-option argument is taken as the sed
            script to interpret

    Change-Id: I69d658254ebe75b07c818e8aa6fb405ff33db549
    Closes-bug: #1553154

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.