Task from example_v3 plugin was run twice

Bug #1560026 reported by Vladimir Khlyunev
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Georgy Kibardin
Mitaka
Fix Released
High
Georgy Kibardin

Bug Description

Swarm test failed
https://product-ci.infra.mirantis.net/job/9.0.system_test.ubuntu.plugins.fuel_plugin_example/53/testReport/%28root%29/deploy_ha_one_controller_neutron_example_v3/deploy_ha_one_controller_neutron_example_v3/

ISO: 9.0-90
Snapshot: https://product-ci.infra.mirantis.net/job/9.0.system_test.ubuntu.plugins.fuel_plugin_example/53/artifact/logs/fail_error_deploy_ha_one_controller_neutron_example_v3-fuel-snapshot-2016-03-21_00-23-21.tar.xz

Steps:
Upload&install example v3 plugin
Create cluster, enable the plugin
Add 1 node with controller role
Add 1 node with compute role
Add 1 node with custom role
Deploy the cluster
Run network verification
Check plugin health << Failed here

Fail reason:
The test met 'PLUGIN: fuel_plugin_example_v3 - deploy.pp' string twice in puppet.log on controller which indicates that the task was executed twice.

Dmitry Klenov (dklenov)
Changed in fuel:
importance: Undecided → Medium
tags: added: area-python
Changed in fuel:
assignee: nobody → Fuel Python Team (fuel-python)
status: New → Confirmed
Revision history for this message
Bug Checker Bot (bug-checker) wrote : Autochecker

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

actual result

expected result

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

tags: added: need-info
tags: added: keep-in-9.0
Dmitry Pyzhov (dpyzhov)
tags: added: team-enhancements
Revision history for this message
Vladimir Kuklin (vkuklin) wrote :

Actually, if you look into the logs, you will see that this is just a way of how puppet reports its logs. This is not the root cause. This bug is actually a duplicate of another one.

Revision history for this message
Dmitry Pyzhov (dpyzhov) wrote :

We passed SCF for 9.0. Moving medium bug to the Newton release

Changed in fuel:
milestone: 9.0 → 10.0
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
assignee: Fuel Python (Deprecated) (fuel-python) → Fuel Sustaining (fuel-sustaining-team)
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
assignee: Fuel Sustaining (fuel-sustaining-team) → Georgy Kibardin (gkibardin)
tags: added: 9-1-scope
Changed in fuel:
status: Confirmed → Incomplete
status: Incomplete → In Progress
Revision history for this message
Georgy Kibardin (gkibardin) wrote :

I'm putting this on hold until this https://review.openstack.org/#/c/333211/ is merged. Puppet debug logs could tell us more about why deploy.pp seemed to be applied twice.

Dmitry Pyzhov (dpyzhov)
tags: removed: 9-1-scope
Revision history for this message
Georgy Kibardin (gkibardin) wrote :
Revision history for this message
Georgy Kibardin (gkibardin) wrote :

My bad, no debug logs, haven't cherrypicked to the stable/mitaka :(

Revision history for this message
Georgy Kibardin (gkibardin) wrote :
Revision history for this message
Georgy Kibardin (gkibardin) wrote :

The change has been merged on July, 19, waiting for the problem to reproduce.

Changed in fuel:
status: In Progress → Incomplete
Revision history for this message
ElenaRossokhina (esolomina) wrote :
Revision history for this message
Georgy Kibardin (gkibardin) wrote :

Guys, were there any changes recently on srv85? Like reinstalling it from scratch, or just libvirt or fuel-devops update? It, actually, was green quite recently.

Also, please ensure that syslinux is installed on the slave where the test is being run.

Revision history for this message
Georgy Kibardin (gkibardin) wrote :

Oops, sorry - wrong window :(

Revision history for this message
Andrey Lavrentyev (alavrentyev) wrote :
tags: added: swarm-fail
Revision history for this message
Sergey Shevorakov (sshevorakov) wrote :

Moving to High, since it fails 1 Swarm TC

Revision history for this message
Georgy Kibardin (gkibardin) wrote :

Could you please include this https://review.openstack.org/#/c/354644/ commit into the build?

Revision history for this message
Dmitry Pyzhov (dpyzhov) wrote :

This bug is medium priority because it doesn't create any issues for users.

Revision history for this message
Timur Nurlygayanov (tnurlygayanov) wrote :

Status changed to Confirmed because the issue reproduced again.

Changed in fuel:
status: Incomplete → Confirmed
importance: Medium → High
Revision history for this message
Timur Nurlygayanov (tnurlygayanov) wrote :

Status changed to High because it affects SWARM pass rate and can affect our customers in the result.

Revision history for this message
Georgy Kibardin (gkibardin) wrote :

It CANNOT affect customers! Applying puppet manifest twice gives the same result.

Revision history for this message
Dmitry Pyzhov (dpyzhov) wrote :

This is a medium priority issue that doesn't affect customers and we still waiting for extra debug info.

Changed in fuel:
importance: High → Medium
status: Confirmed → Incomplete
Revision history for this message
ElenaRossokhina (esolomina) wrote :
Revision history for this message
Georgy Kibardin (gkibardin) wrote :

Sure, but I need either to reproduce it locally or run the test with my patch https://review.openstack.org/#/c/354644/

Changed in fuel:
importance: Medium → High
Revision history for this message
Tatyana Borukhovich (tatyanaborukhovich) wrote :

Can we please get ETA for this bug fix, it is currently blocking one of the fixes that QA needs to fix Swarm blocking issue.

Revision history for this message
Georgy Kibardin (gkibardin) wrote :

Reproduced an issue with more logging. This is for sure not a graph related issue. PuppetTask is run by Astute only once.

Revision history for this message
Georgy Kibardin (gkibardin) wrote :
Revision history for this message
Georgy Kibardin (gkibardin) wrote :

ETA is 2-3 days.

Revision history for this message
Georgy Kibardin (gkibardin) wrote :
Revision history for this message
Georgy Kibardin (gkibardin) wrote :

The reason is that we poll puppet status somewhere inbetween puppets writes to its status file. At this point puppet status is already written, but the timestamp of the last run is not. This breaks Astute logic around this.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-astute (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/374033

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-astute (stable/mitaka)

Reviewed: https://review.openstack.org/374033
Committed: https://git.openstack.org/cgit/openstack/fuel-astute/commit/?id=e5311dd97b4120d7aacd19b812e5548cfa5fd5e9
Submitter: Jenkins
Branch: stable/mitaka

commit e5311dd97b4120d7aacd19b812e5548cfa5fd5e9
Author: Georgy Kibardin <email address hidden>
Date: Wed Sep 21 13:58:45 2016 +0300

    Remove puppet status files right before running it

    This prevents us from picking up status files from previous run when
    current run hasn't written them for some reason, i.e. crash etc.

    Change-Id: I83d0b4aa3c42210279b75ed7b575919d2d092ff0
    Closes-Bug: #1560026

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-astute (master)

Fix proposed to branch: master
Review: https://review.openstack.org/374221

Changed in fuel:
status: Incomplete → In Progress
tags: added: on-verification
Revision history for this message
Margarita Bliznikova (mbliznikova) wrote :
tags: removed: on-verification
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-astute (master)

Reviewed: https://review.openstack.org/374221
Committed: https://git.openstack.org/cgit/openstack/fuel-astute/commit/?id=ac2703949fdbb9160a4ea6b722e9f1855356577f
Submitter: Jenkins
Branch: master

commit ac2703949fdbb9160a4ea6b722e9f1855356577f
Author: Georgy Kibardin <email address hidden>
Date: Wed Sep 21 13:58:45 2016 +0300

    Remove puppet status files right before running it

    This prevents us from picking up status files from previous run when
    current run hasn't written them for some reason, i.e. crash etc.

    Change-Id: I83d0b4aa3c42210279b75ed7b575919d2d092ff0
    Closes-Bug: #1560026
    (cherry picked from commit e5311dd97b4120d7aacd19b812e5548cfa5fd5e9)

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-astute 10.0.0rc1

This issue was fixed in the openstack/fuel-astute 10.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-astute 10.0.0

This issue was fixed in the openstack/fuel-astute 10.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.