Node keeps 'Error' status after deletion

Bug #1576590 reported by ElenaRossokhina
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Julia Aranovich
Mitaka
Fix Released
High
Julia Aranovich
Newton
Fix Committed
High
Julia Aranovich

Bug Description

Detailed bug description:
I've tried to deploy cluster, but if failed on 1 compute node. After that I deleted error node using GUI, but node still has "ERROR" state instead of "Pending Deletion". For this node "Delete" button became invisible.
Also, I deleted one more node that had "ready" status, and it looks OK: node has "Pending Deletion" state and "Delete" button is unavailable for it
Steps to reproduce:
My claster is: Neutron VLAN, seph for all;3 controllers, 1 compute, 3 ceph
Actually bug can be reproduced with any cluster having error nodes
Expected results:
Node staus is changed.
Actual result:
 Node saves it status in gui.
Reproducibility:
Actually bug can be reproduced with any cluster having error nodes
Workaround:
n/a
Impact:
n/a
Description of the environment:
9.0 iso#250
Additional information:
'fuel nodes' output is attached too

Tags: area-ui
Revision history for this message
ElenaRossokhina (esolomina) wrote :
Revision history for this message
ElenaRossokhina (esolomina) wrote :

Here is a picture to show more details

Revision history for this message
ElenaRossokhina (esolomina) wrote :
tags: added: area-python
Dmitry Pyzhov (dpyzhov)
no longer affects: fuel/newton
Changed in fuel:
assignee: Fuel Toolbox (fuel-toolbox) → Vladimir Kuklin (vkuklin)
Revision history for this message
Vladimir Kuklin (vkuklin) wrote :

Logs contain the following error message:

Cannot evaluate expression - 'changedAny($.network_scheme, $.dpdk, $.get('use_ovs'), $.get('set_rps'), $.get('set_rps'), $.get('run_ping_checker'), $.network_scheme.endpoints.values().where(
  $.get('gateway') != null).gateway)) for task netconfig. <- here we can clearly see a redundant parentheses in the YAQL expression

But if I open our stable/mitaka or master code I do not see this redundant parentheses. To me it seems like this bug is at least Incomplete. Please, reopen if you face this issue with the newer ISO

Changed in fuel:
status: Confirmed → Incomplete
Revision history for this message
Vladimir Kuklin (vkuklin) wrote :

Reopened after talking to bug reporter. Seems to be clearly UI issue.

Changed in fuel:
status: Incomplete → Confirmed
assignee: Vladimir Kuklin (vkuklin) → Fuel UI Team (fuel-ui)
Revision history for this message
Vitaly Kramskikh (vkramskikh) wrote :

Ui doesn't set node state, it's Nailgun bug. Can't find suitable team though

Changed in fuel:
assignee: Fuel UI Team (fuel-ui) → nobody
Changed in fuel:
assignee: nobody → Fuel Toolbox (fuel-toolbox)
Revision history for this message
Alexandra (aallakhverdieva) wrote :

https://drive.google.com/open?id=0BxmbtGZe1aPtc3NMSktUZ09wSEk
My configuration:
1 controller
2 computes (8 cpus, 18 GB ram, 165 Gb hdd) + ceph
1 compute (6 cpus, 18 GB ram, 165 Gb hdd)
Deploy has been failed for compute without ceph
The I have the same issue with node deletion

Revision history for this message
Alexandra (aallakhverdieva) wrote :
Revision history for this message
Ihor Kalnytskyi (ikalnytskyi) wrote :

Alexandra,

I've took a look onto your logs. It seems they irrelevant to this problem. I didn't find any information about attempting to remove some node. Neither Astute.log not DB dump contain that information. You probably attach wrong snapshot or didn't remove node on your env.

Revision history for this message
Ihor Kalnytskyi (ikalnytskyi) wrote :

As Vova said, in first snapshot there's a YAQL parsing error indeed. It's not something we bring within Fuel. According to api.log, ill-formed task were pushed via API right before trying to lunch deployment. After error, it was replaced with correct format.

Revision history for this message
Ihor Kalnytskyi (ikalnytskyi) wrote :

Well, I found out that someone marked:

* node 4 for deletion at 08:35 29/04/2016
* node 3 for deletion at 08:36 29/04/2016

However, no one press "Deploy Changes" after that. The last hit of Deploy Changes was at 07:26 29/04/2016 and ended with error at 08:26 29/04/2016.

That basically means, there were no chance to do "node removal" since no one hit "Deploy Changes".

According to that investigation, I move that bug to Invalid.

Revision history for this message
ElenaRossokhina (esolomina) wrote :

It seems, issue was explained not clearly, sorry.
Issue is about only node's statuses in GUI, before redeploy and real deletion.
I reproduced the problem again: I have an env with 2 nodes in 'Error' state and try to delete one node using GUI. I select node and press "Delete" button but nothing changes. I see node in 'error' state, not 'pending deletion' - see pic error_node2
If I check node 2 status in cli:
[root@nailgun ~]# fuel2 node show 2 | grep pending_del
| pending_deletion | True Also, I have env after correct deployment and if I select node and press "Delete", the chosen node will have 'Pending deletion' status both in GUI and CLI

Revision history for this message
Ihor Kalnytskyi (ikalnytskyi) wrote :

Elena,

Thank you fore shedding light on details. Now it's clear:

* No issues on backend - pending_deletion is True.
* Fuel UI provides confusing UX - pending deletion status is hidden, and error on top of it.

I think the best option would be to show both statuses: "pending deletion / error" or "pending deletion / ready". Anyway, it's up to UI team. Hence, assign this bug to them.

tags: added: area-ui
removed: area-python
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-ui (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/324642

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/325060

Changed in fuel:
assignee: Fuel UI Team (fuel-ui) → Julia Aranovich (jkirnosova)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-ui (master)

Reviewed: https://review.openstack.org/325060
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=a143c5c9c720031f4ad557f09e1d9d4dadf8cd54
Submitter: Jenkins
Branch: master

commit a143c5c9c720031f4ad557f09e1d9d4dadf8cd54
Author: Julia Aranovich <email address hidden>
Date: Thu Jun 2 19:05:40 2016 +0300

    Reprioritize node statuses

    * pending addition/pending deletion node states have bigger priority
      than node status and appropriate labels should be shown on a node panel
    * pending addition/pending deletion states removed from node list
      sorting by node status

    Closes-Bug: #1576590

    Change-Id: I4efa6d9063a49a4c6737c21a27c141f24ee944fb

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-ui (stable/mitaka)

Reviewed: https://review.openstack.org/324642
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=04914c99d699c201c3b14bc71da3cc7932dff7f9
Submitter: Jenkins
Branch: stable/mitaka

commit 04914c99d699c201c3b14bc71da3cc7932dff7f9
Author: Julia Aranovich <email address hidden>
Date: Thu Jun 2 19:05:40 2016 +0300

    Reprioritize node statuses

    * pending addition/pending deletion node states have bigger priority
      than node status and appropriate labels should be shown on a node panel
    * pending addition/pending deletion states removed from node list
      sorting by node status

    Closes-Bug: #1576590

    Change-Id: I4efa6d9063a49a4c6737c21a27c141f24ee944fb

tags: added: on-verification
Revision history for this message
Grigory Mikhailov (gmikhailov) wrote :

Verified on #fuel-9.0-mos-492 iso.
After deletion node status is observed correctly.

[root@nailgun ~]# shotgun2 short-report
cat /etc/fuel_build_id: 492
cat /etc/fuel_build_number: 492
cat /etc/fuel_release: 9.0
cat /etc/fuel_openstack_version: mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6349.noarch
 fuel-misc-9.0.0-1.mos8460.noarch
 python-packetary-9.0.0-1.mos140.noarch
 fuel-bootstrap-cli-9.0.0-1.mos285.noarch
 fuel-migrate-9.0.0-1.mos8460.noarch
 rubygem-astute-9.0.0-1.mos750.noarch
 fuel-mirror-9.0.0-1.mos140.noarch
 shotgun-9.0.0-1.mos90.noarch
 fuel-openstack-metadata-9.0.0-1.mos8743.noarch
 fuel-notify-9.0.0-1.mos8460.noarch
 nailgun-mcagents-9.0.0-1.mos750.noarch
 python-fuelclient-9.0.0-1.mos325.noarch
 fuel-9.0.0-1.mos6349.noarch
 fuel-utils-9.0.0-1.mos8460.noarch
 fuel-setup-9.0.0-1.mos6349.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8743.noarch
 fuel-library9.0-9.0.0-1.mos8460.noarch
 network-checker-9.0.0-1.mos74.x86_64
 fuel-agent-9.0.0-1.mos285.noarch
 fuel-ui-9.0.0-1.mos2717.noarch
 fuel-ostf-9.0.0-1.mos936.noarch
 fuelmenu-9.0.0-1.mos274.noarch
 fuel-nailgun-9.0.0-1.mos8743.noarch

tags: removed: on-verification
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.