Fuel for OpenStack

The previous states should not be used for the context evaluation if there was no successful deployment after last provisioning

Bug #1582269 reported by Arthur Svechnikov on 2016-05-16

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Fuel for OpenStack	Fix Committed	High	Nikita Zubkov	Fuel for OpenStack 10.0
Mitaka	Fix Released	High	Nikita Zubkov	Fuel for OpenStack 9.0
Newton	Fix Committed	High	Nikita Zubkov	Fuel for OpenStack 10.0

Bug Description

Detailed bug description:
Currently, transactions are not deleted after node re-provision or cluster reset. It's lead to incorrect transaction processing. In fact, a node shouldn't have any deployment history. Otherwise, it's highly possible that deployment won't work at all.
Steps to reproduce:
1. Deploy 1 controller
2. Re-provision controller
3. Deploy controller
4. Stop deploy
5. Resume deploy
Expected results:
All steps are passed
Actual result:
Step 5 failed due to inconsistency of transactions
Workaround:
Don't use stop deploy

Tags:

Arthur Svechnikov (asvechnikov) on 2016-05-16

Changed in fuel:
milestone:	none → 10.0

Revision history for this message

Bug Checker Bot (bug-checker) wrote on 2016-05-17: Autochecker

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

version

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

tags:

added: need-info

Revision history for this message

Alexey Shtokolov (ashtokolov) wrote on 2016-05-19: Re: Transactions are not deleted after re-install or cluster reset

The root cause: we shouldn't use a context for deployment if there was no successful deployment after last provisioning.

summary:	- Transactions are not deleted after re-install or cluster reset + The previous states should not be used for context evaluation if there + was no successful deployment after last provisioning
summary:	- The previous states should not be used for context evaluation if there - was no successful deployment after last provisioning + The previous states should not be used for the context evaluation if + there was no successful deployment after last provisioning

Dmitry Pyzhov (dpyzhov) on 2016-05-19

tags:

added: area-python

Revision history for this message

Nikita Zubkov (zubchick) wrote on 2016-05-23:

https://review.openstack.org/#/c/317614/

OpenStack Infra (hudson-openstack) on 2016-05-23

Changed in fuel:
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-24: Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/317614
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=5ba7416156786e6d409c6f3a969441b55c2ea2bb
Submitter: Jenkins
Branch: master

commit 5ba7416156786e6d409c6f3a969441b55c2ea2bb
Author: Nikita Zubkov <email address hidden>
Date: Tue May 17 19:10:02 2016 +0300

Fix getting previous state for deployment

    Now we get last success transaction not only for every task but for
    every node in the cluster. The previous version of state collecting
    function may lead to false-positive choice of previous deployment
    transaction and issues with smart YAQL-based redeployment.

    Change-Id: If9e22924acb465487a2fa97534fe50f03a1590a1
    Closes-Bug: #1581015
    Closes-Bug: #1582269

Changed in fuel:
status:	In Progress → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-24: Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/320329

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-24: Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/320329
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=48cb2465e0e04b8a6fb03b740560be929dd2a75f
Submitter: Jenkins
Branch: stable/mitaka

commit 48cb2465e0e04b8a6fb03b740560be929dd2a75f
Author: Nikita Zubkov <email address hidden>
Date: Tue May 17 19:10:02 2016 +0300

Fix getting previous state for deployment

    Change-Id: If9e22924acb465487a2fa97534fe50f03a1590a1
    Closes-Bug: #1581015
    Closes-Bug: #1582269
    (cherry picked from commit 5ba7416156786e6d409c6f3a969441b55c2ea2bb)