Fuel for OpenStack

Can't upload network template with private interface without vlan tag

Series mitaka
Bug #1602817

Bug #1602817 reported by Max Lvov on 2016-07-13

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Fuel for OpenStack	Fix Committed	High	Georgy Kibardin	Fuel for OpenStack 10.1
8.0.x	Confirmed	Medium	Dmitry Dmitriev	Fuel for OpenStack 8.0-updates
Mitaka	Fix Committed	Medium	Max Yatsenko	Fuel for OpenStack 9.x-updates

Bug Description

Here is template http://pastebin.com/M6LmQnQ3
What I do:
1 Create env
2 Add some nodes to cluster
3 In template remove .999 from prv interface
4 Try to upload

What I expect:
Template uploaded:
What I get:
500 Internal server error ('id')
and no details in any log

Another way:
Do not proceed step 2
Ensure you don't have any nodes in cluster
Upload template.
Add nodes to cluster.

What I expect:
Nodes assigned
What I get:
I can't assign nodes to any role with private network

Also, this bug affected by https://bugs.launchpad.net/fuel/+bug/1539115 which makes troubleshooting very difficult.

See original description

Tags:

Revision history for this message

Max Lvov (usrleon) wrote on 2016-07-13:

This bug seems to appear only if I use private network mapped to physical interface and doesn't appear if use sub-interface like eth0.999
Once I will have access to env, I will attach network template.

Revision history for this message

Max Lvov (usrleon) wrote on 2016-07-14:

Fixed bug cation and description

description:	updated
summary:	- Can't upload network template when nodes in cluster + Can't upload network template with private interface without vlan tag

Dmitry Klenov (dklenov) on 2016-07-15

tags:

added: area-python

Maksim Malchuk (mmalchuk) on 2016-07-15

no longer affects:

fuel/newton

Revision history for this message

Max Lvov (usrleon) wrote on 2016-07-15:

Sorry, forgot to mention this was on 8.0

Revision history for this message

Max Lvov (usrleon) wrote on 2016-07-15:

Ryan Moe has the fix for that. It works, but he wants to test it before to publish.

Dmitry Pyzhov (dpyzhov) on 2016-07-18

Changed in fuel:
assignee:	Fuel Sustaining (fuel-sustaining-team) → l23network (l23network)

Roman Zhnichkov (rzhnichkov) on 2016-07-20

tags:

added: customer-found

Revision history for this message

Dmitry Dmitriev (dmdmitriev) wrote on 2016-07-29:

I have successfully uploaded template without VLAN tag on:

- Fuel 8
- Fuel 8 MU2

Template will be attached.

Revision history for this message

Dmitry Dmitriev (dmdmitriev) wrote on 2016-07-29:

network_template_1_custom.yaml Edit (5.3 KiB, text/plain)

Revision history for this message

Max Lvov (usrleon) wrote on 2016-08-08:

nailgun_private_iface.patch Edit (905 bytes, text/plain)

This patch was created by Ryan Moe and fixed my problem.

Dmitry Pyzhov (dpyzhov) on 2016-09-12

Changed in fuel:
assignee:	Registry Administrators (registry) → Fuel Sustaining (fuel-sustaining-team)

Dmitry Pyzhov (dpyzhov) on 2016-09-13

Changed in fuel:
assignee:	Fuel Sustaining (fuel-sustaining-team) → Dmitry Guryanov (dguryanov)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-28: Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/391410

Changed in fuel:
status:	Confirmed → In Progress

Dmitry Pyzhov (dpyzhov) on 2016-11-23

Changed in fuel:
assignee:	Dmitry Guryanov (dguryanov) → Fuel Sustaining (fuel-sustaining-team)

OpenStack Infra (hudson-openstack) on 2016-11-23

Changed in fuel:
assignee:	Fuel Sustaining (fuel-sustaining-team) → Alexander Kislitsky (akislitsky)

Dmitry Pyzhov (dpyzhov) on 2016-12-22

Changed in fuel:
milestone:	10.0 → 10.1

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-03: Change abandoned on fuel-web (master)

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: master
Review: https://review.openstack.org/391410
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message

Max Lvov (usrleon) wrote on 2017-01-31:

#10

Just affected this bug again on 9.1. Patch again helped.

Revision history for this message

Max Lvov (usrleon) wrote on 2017-01-31:

#11

Some correction:
this time it was not private, but private-like custom network.

Revision history for this message

Max Lvov (usrleon) wrote on 2017-02-03:

#12

Could someone finish that abandoned proposal?

OpenStack Infra (hudson-openstack) on 2017-05-04

Changed in fuel:
assignee:	Alexander Kislitsky (akislitsky) → Georgy Kibardin (gkibardin)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-05-10: Fix merged to fuel-web (master)

#13

Reviewed: https://review.openstack.org/391410
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=392f3859ff501489517668291b01f7fc46e759c8
Submitter: Jenkins
Branch: master

commit 392f3859ff501489517668291b01f7fc46e759c8
Author: Dmitry Guryanov <email address hidden>
Date: Fri Oct 28 13:20:09 2016 +0300

Calculation of interface types from templates fixed

    In case of adding port on bond 'ether' type was set
    for interface. This was root cause of the issue -
    bond was processed as nic.

Closes-Bug: #1602817
Change-Id: I6a5136ce9ce5398aa6d55c795857769a7a41f7b0

Changed in fuel:
status:	In Progress → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-07-14: Fix merged to fuel-web (stable/mitaka)

#14

Reviewed: https://review.openstack.org/482896
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=7a9cd4197bc0e1373cc2aeb2f3ff9a5f6a9c7485
Submitter: Jenkins
Branch: stable/mitaka

commit 7a9cd4197bc0e1373cc2aeb2f3ff9a5f6a9c7485
Author: Max Yatsenko <email address hidden>
Date: Wed Jul 12 13:34:03 2017 +0300

Calculation of interface types from templates fixed

      In case of adding port on bond 'ether' type was set
    for interface. This was root cause of the issue -
    bond was processed as nic.
      This patch was based on [1] patch, but it was
    adapted for 'mitaka'.

[1] https://review.openstack.org/#/c/391410/

Closes-Bug: #1602817

Change-Id: I2fb14eac3874796bfb099db0b681db253351850c