[system-tests] get_nailgun_node_by_devops_node returns None when node was not discovered by nailgun

Bug #1517034 reported by Vladimir Khlyunev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Confirmed
Medium
Vladimir Khlyunev
Mitaka
Won't Fix
Medium
Vladimir Khlyunev
Newton
Confirmed
Medium
Vladimir Khlyunev

Bug Description

Steps to repro:
1) Run prepare_release test
2) Execute a test with
self.env.revert_snapshot("ready")
self.fuel_web.wait_nodes_get_online_state(env.d_env.nodes().slaves, timeout=30 * 60) line for snapshot

Result:
TypeError: 'NoneType' object has no attribute '__getitem__'
Traceback without clear message.

RCA:
This happens because nodes wasn't discovered by nailgun and fuel_web.wait_nodes_get_online_state doesn't raise any error in that case.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (master)

Fix proposed to branch: master
Review: https://review.openstack.org/246379

Changed in fuel:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (master)

Reviewed: https://review.openstack.org/246379
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=801e5225cd64f89080ef0f6fcbf14aef60896f93
Submitter: Jenkins
Branch: master

commit 801e5225cd64f89080ef0f6fcbf14aef60896f93
Author: Vladimir Khlyunev <email address hidden>
Date: Tue Nov 17 16:13:29 2015 +0300

    Raise error when node was not found in nailgun

    For improving logging and avoiding TypeError we should raise an error
    here in case when a slave wasn't added to nailgun database.

    Change-Id: Iaff6e6844a1e76fe0f292ff82be1d4cf083e946a
    Closes-bug:#1517034

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Tatyanka (tatyana-leontovich) wrote :

reopen according to commit was reverted due to regression that blocks bvt introduces

Changed in fuel:
status: Fix Committed → Confirmed
Revision history for this message
Tatyanka (tatyana-leontovich) wrote :

move to 9.0 according to we do not fix medium issues in 8.0 anymore

Changed in fuel:
milestone: 8.0 → 9.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.