New page hook adds title-block to empty schematic file

Bug #698535 reported by Peter Clifton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gEDA
New
Medium
Unassigned

Bug Description

Opening an empty (but valid) schematic file causes gschem's new-page-hook to place a title-block.

The new page hook should probably NOT be run for pages loaded from disk.

(Although it probably should be run for the new-page created when a page _cannot_ be loaded from disk, e.g. because the a file specified to open doesn't exist).

Tags: gschem sf-bugs
Peter TB Brett (peter-b)
Changed in geda:
importance: Undecided → Medium
status: New → Confirmed
Peter TB Brett (peter-b)
Changed in geda:
milestone: none → 1.8.0
Revision history for this message
Eivind Kvedalen (eivind-z) wrote :

This bug seems to be gone after the scheme-api merge.

Revision history for this message
Peter TB Brett (peter-b) wrote : Re: gEDA-bug: [Bug 698535] Re: New page hook adds title-block to emptyschematic file

On Thursday 30 June 2011 20:52:56 Eivind Kvedalen wrote:
> This bug seems to be gone after the scheme-api merge.

That's because it is.

 status fixcommitted

Changed in geda:
status: Confirmed → Fix Committed
Peter TB Brett (peter-b)
Changed in geda:
status: Fix Committed → Fix Released
Revision history for this message
Peter Clifton (pcjc2) wrote :

I want to re-open this, it has broken new-page functionality in xgsch2pcb.

As stated in the original report, we should probably run the new-page hook when a page _cannot_ be loaded from disk, e.g. because the a file specified to open doesn't exist.

Alternative - add some means to invoke gschem to create a new page, and pre-specify the filename to save into.

Changed in geda:
status: Fix Released → New
Revision history for this message
Peter Clifton (pcjc2) wrote :

(Note that the alternative breaks old xgsch2pcb behaviour though).. You can twist my arm if you hate the idea of running the new-page hook for a "can't load" case.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.