Geis

geis crashes when accepting gesture

Bug #1015775 reported by Daniel d'Andrada
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Geis
Fix Released
High
Daniel d'Andrada
Geis 2.2.11
geis (Ubuntu)
Fix Released
Undecided
Unassigned
Precise
Fix Released
High
Francis Ginther

Bug Description

We need it backported as it fixes a crash bug.

[Test Case]

The following situation leads to a crash:
    - Geis processed the end event of a grail gesture
    - Geis has a number of geis events pending delivery to application
    - Application accepts that ended grail gesture

[Cause]

While checking the queue of pending events for events that should no longer be delivered due to the gesture acceptance, geis would try to use a struct with information from the ended grail gesture that also no longer exists (gesture state info gets deleted when grail gesture ends).

That bug was introduced in revision 265.

[Regression Potential]

Code with this fix has been tested for quite some time now and no regressions were found. This is actually a fix for a regression caused by the fix for bug 1001365.

See original description

Related branches

lp://qastaging/~dandrader/geis/lp1015775
Chase Douglas (community): Approve
Diff: 514 lines (+227/-139)
8 files modified
libutouch-geis/backend/grail/geis_grail_backend.c (+6/-4)
testsuite/geis2/Makefile.am (+1/-0)
testsuite/geis2/gtest_gbe_accept_ended_grail_gesture.cpp (+85/-0)
testsuite/geis2/gtest_gbe_construction_finished.cpp (+4/-4)
testsuite/geis2/gtest_gbe_direct_touch_coords.cpp (+4/-4)
testsuite/geis2/gtest_gbe_outdated_events.cpp (+2/-121)
testsuite/geis2/gtest_grail_backend.cpp (+109/-3)
testsuite/geis2/gtest_grail_backend.h (+16/-3)
lp://qastaging/geis
lp://qastaging/geis/ubuntu
lp://qastaging/ubuntu/quantal/geis
lp://qastaging/~fginther/+junk/geis-precise-debug
lp://qastaging/~fginther/+junk/geis-2.2.9.1-take2
lp://qastaging/~fginther/geis/geis-2.2.9.1-precise
lp://qastaging/ubuntu/precise-proposed/geis
Daniel d'Andrada (dandrader)
Changed in utouch-geis:
status: Confirmed → Fix Committed
Daniel d'Andrada (dandrader)
affects: ubuntu → utouch-geis (Ubuntu)
Chase Douglas (chasedouglas)
Changed in utouch-geis:
milestone: none → 2.1.11
status: Fix Committed → Fix Released
Chase Douglas (chasedouglas)
affects: utouch-geis (Ubuntu) → geis (Ubuntu)
Changed in geis (Ubuntu):
status: New → Fix Released
Chase Douglas (chasedouglas)
Changed in geis (Ubuntu Precise):
status: New → In Progress
importance: Undecided → High
assignee: nobody → Francis Ginther (fginther)
Daniel d'Andrada (dandrader)
description: updated
Revision history for this message
Adam Conrad (adconrad) wrote : Please test proposed package

Hello Daniel, or anyone else affected,

Accepted geis into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/geis/2.2.9.1-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in geis (Ubuntu Precise):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Adam Conrad (adconrad) wrote :

Hello Daniel, or anyone else affected,

Accepted geis into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/geis/2.2.9.2-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

I ran the regression test made for this bug against the libgeis 2.2.9.2-0ubuntu1 present in precise-proposed and it passed.

Also gestures in unity still work as they should, thus no outstanding regressions were seen.

Therefore marking as verified.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package geis - 2.2.9.2-0ubuntu1

---------------
geis (2.2.9.2-0ubuntu1) precise-proposed; urgency=low

  * New upstream release. Only change is the following bug fix:
    - Fixes regression that caused GEISv1 clients, such as Unity, to not work
      (LP: #1047596)

geis (2.2.9.1-0ubuntu1) precise-proposed; urgency=low

  * Update debian/watch file for new project name
  * New upstream release.
    - removes XCB back end
    - removes overlapping events when a gesture is accepted (lp: #1001365)
    - fix for excessive timeout on backend init failure (lp: #997630)
    - detect added devices properly (LP: #1009270)
    - fix crash when accepting a gesture (LP: #1015775)
    - fix result value of geis_subscription_deactivate() (LP: #1021448)
    - upstream project renamed to just 'geis'
  * Update packaging for project rename (LP: #1037621)
    - Added Conflicts and Replaces clauses for libgeis-dev, libgeis-doc,
      python-geis and geis-tools
  * Remove patches that have been integrated into upstream
    - remove lp813819-typedef-geis-subscription-flags.patch
    - remove lp985986-fix-touch-delta-calculation.patch
    - remove lp986215-calculate-pinch-delta-as-ratio.patch
    - remove lp987539-add-device-axis-attributes.patch
    - remove lp997630-avoid-starting-dbus-session-on-remote-connection.patch
    - remove fix-touch-coordinate-space.patch (patch for lp984069)
 -- Chase Douglas <email address hidden> Fri, 07 Sep 2012 14:11:40 -0700

Changed in geis (Ubuntu Precise):
status: Fix Committed → Fix Released
Revision history for this message
Adam Conrad (adconrad) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.