Remove jsonschema as a dependency
Bug #1462937 reported by
Flavio Percoco
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
glance_store |
Confirmed
|
Wishlist
|
Unassigned |
Bug Description
The filesystem store uses jsonschema to parse the metadata files. While jsonschema does the validation job very well, I believe it's an unnecessary dependency for such a small validation to do and for such a small use-case.
I'd rather have this specific check done directly when accessing these values in python than having an extra dependency.
Changed in glance-store: | |
assignee: | nobody → Flavio Percoco (flaper87) |
Changed in glance-store: | |
assignee: | Flavio Percoco (flaper87) → nobody |
tags: | added: lite-spec |
To post a comment you must log in.
I don't have much of a preference on this. On the one hand, utilizing it rather than reinventing the wheel for checking the json format is probably better, and it's not a large overhead since a lot of openstack also has it as a dependency. As you say, though, we're basically using it to check two values in one place in the code, which seems like overkill: /github. com/openstack/ glance_ store/blob/ cb4c615e8495590 983330b01c0cdaa 272abf1181/ glance_ store/_ drivers/ filesystem. py#L72- 82
https:/