It doesn't make sense to throw web.exc.Exception from notifier level
Bug #1256220 reported by
Feilong Wang
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Glance |
Triaged
|
Wishlist
|
Feilong Wang | ||
Bug Description
Based on current code, there are lots of web.exc.Exception thrown from notifier level, see https:/
But I think it would make more sense to throw this kind of exceptions from the API level. Given we're trying to catch the internal Glance exception instead of web.exc.Exception, see https:/
| Changed in glance: | |
| assignee: | nobody → Fei Long Wang (flwang) |
Revision history for this message
| Flavio Percoco (flaper87) wrote | #1 |
| Changed in glance: | |
| status: | New → Triaged |
| importance: | Undecided → Wishlist |
To post a comment you must log in.
Agreed!
It may make some sense to throw those exceptions from within the Proxies in the domain level, this can be argued, though. What seems a bit weirder to me is having proxies defined within the notifier module. I think this is a good time to refactor the code a bit and move the proxies and domain levels under the same package. IMHO, they should be under a version package as well, since they may change between different api versions.