Global menubar extension

Firefox 4 crashes when opening Selenium IDE window

Bug #783790 reported by Luiz Armesto
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Global menubar extension
Fix Released
Critical
Chris Coulson
1.0
Fix Released
Critical
Chris Coulson
Global menubar extension 1.0.5
firefox (Ubuntu)
Fix Released
High
Chris Coulson
Natty
Fix Released
High
Chris Coulson
Ubuntu natty-updates

Bug Description

*** TEST CASE FOR SRU ***
You need to disable addon compat checking here, so you might want to test in a temporary profile. Run "firefox -ProfileManager" to create one

Preparation:
1) Install addon compatibility reporter from https://addons.mozilla.org/en-US/firefox/addon/add-on-compatibility-reporter/?src=api
2) Install the Selenium extension from http://release.seleniumhq.org/selenium-ide/1.0.10/selenium-ide-1.0.10.xpi

Test:
1) Run firefox and select Tools -> Selenium IDE

Results:
The old version shall crash
With the new version, the Selenium window will appear with a functional menubar in the panel

When trying to open the Selenium IDE using Firefox 4 with Global Menu Bar Integration enabled its crash as soon as the Selenium IDE window is created. Disabling the Global Menu Bar Integration its run as expected.

Versions:
firefox 4.0.1+build1+nobinonly-0ubuntu0.11.04.2
firefox-globalmenu 4.0.1+build1+nobinonly-0ubuntu0.11.04.2 (1.0.3)
Selenium IDE 1.0.11

Backtrace:
$ firefox -g
GNU gdb (Ubuntu/Linaro 7.2-1ubuntu11) 7.2
Copyright (C) 2010 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law. Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>...
Reading symbols from /usr/lib/firefox-4.0.1/firefox-bin...Reading symbols from /usr/lib/debug/usr/lib/firefox-4.0.1/firefox-bin...done.
done.
(gdb) run
Starting program: /usr/lib/firefox-4.0.1/firefox-bin
[Thread debugging using libthread_db enabled]
[New Thread 0x7fffe69ff700 (LWP 9796)]
[New Thread 0x7fffe5ffa700 (LWP 9797)]
[New Thread 0x7fffe57f9700 (LWP 9798)]
[New Thread 0x7fffe4c96700 (LWP 9799)]
[New Thread 0x7fffe41ff700 (LWP 9800)]
[New Thread 0x7fffe37ff700 (LWP 9801)]
[New Thread 0x7fffe2ffe700 (LWP 9802)]
[New Thread 0x7fffdfeb3700 (LWP 9803)]
[New Thread 0x7fffdf4ff700 (LWP 9804)]
[New Thread 0x7fffde9ff700 (LWP 9805)]
[New Thread 0x7fffde1fe700 (LWP 9806)]
[Thread 0x7fffdfeb3700 (LWP 9803) exited]
[Thread 0x7fffde9ff700 (LWP 9805) exited]
[New Thread 0x7fffdfeb3700 (LWP 9807)]
[Thread 0x7fffdfeb3700 (LWP 9807) exited]
[New Thread 0x7fffdfeb3700 (LWP 9808)]
[New Thread 0x7fffde9ff700 (LWP 9809)]
[New Thread 0x7fffd81ff700 (LWP 9810)]
[New Thread 0x7fffd79fe700 (LWP 9811)]
[New Thread 0x7fffd71fd700 (LWP 9812)]
[New Thread 0x7fffd69fc700 (LWP 9813)]
[Thread 0x7fffd81ff700 (LWP 9810) exited]
[Thread 0x7fffd79fe700 (LWP 9811) exited]
[Thread 0x7fffde1fe700 (LWP 9806) exited]
[Thread 0x7fffd69fc700 (LWP 9813) exited]
[New Thread 0x7fffde1fe700 (LWP 9814)]
[New Thread 0x7fffd69fc700 (LWP 9815)]
[New Thread 0x7fffd81ff700 (LWP 9816)]
[New Thread 0x7fffd79fe700 (LWP 9817)]

(firefox-bin:9793): LIBDBUSMENU-GTK-CRITICAL **: dbusmenu_menuitem_property_set_shortcut: assertion `gtk_accelerator_valid(key, modifier)' failed
[New Thread 0x7fffd55ff700 (LWP 9819)]
[New Thread 0x7fffd4aff700 (LWP 9820)]
[New Thread 0x7fffd42fe700 (LWP 9821)]
[New Thread 0x7fffd3afd700 (LWP 9822)]
[New Thread 0x7fffd2cff700 (LWP 9823)]

Program received signal SIGSEGV, Segmentation fault.
0x00007fffe04ef1a1 in GetOwnerDoc (this=0x7fffd1f76860)
    at /build/buildd/firefox-4.0.1+build1+nobinonly/build-tree/mozilla/extensions/globalmenu/components/src/uGlobalMenu.cpp:655
655 /build/buildd/firefox-4.0.1+build1+nobinonly/build-tree/mozilla/extensions/globalmenu/components/src/uGlobalMenu.cpp: No such file or directory.
 in /build/buildd/firefox-4.0.1+build1+nobinonly/build-tree/mozilla/extensions/globalmenu/components/src/uGlobalMenu.cpp
(gdb) backtrace
#0 0x00007fffe04ef1a1 in GetOwnerDoc (this=0x7fffd1f76860)
    at /build/buildd/firefox-4.0.1+build1+nobinonly/build-tree/mozilla/extensions/globalmenu/components/src/uGlobalMenu.cpp:655
#1 uGlobalMenu::AboutToOpen (this=0x7fffd1f76860)
    at /build/buildd/firefox-4.0.1+build1+nobinonly/build-tree/mozilla/extensions/globalmenu/components/src/uGlobalMenu.cpp:189
#2 0x00007fffe04ef4d2 in uGlobalMenu::MenuAboutToOpenCallback (
    menu=<value optimized out>, data=<value optimized out>)
    at /build/buildd/firefox-4.0.1+build1+nobinonly/build-tree/mozilla/extensions/globalmenu/components/src/uGlobalMenu.cpp:95
#3 0x00007ffff2c0081c in g_closure_invoke ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#4 0x00007ffff2c12019 in ?? () from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#5 0x00007ffff2c1afa9 in g_signal_emit_valist ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#6 0x00007ffff2c1b41f in g_signal_emit ()
   from /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
#7 0x00007fffe00c1735 in ?? () from /usr/lib/libdbusmenu-glib.so.3
#8 0x00007fffe00c4637 in ?? () from /usr/lib/libdbusmenu-glib.so.3
#9 0x00007ffff43d3350 in ?? () from /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
#10 0x00007ffff2538bcd in g_main_context_dispatch ()
   from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#11 0x00007ffff25393a8 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#12 0x00007ffff2539639 in g_main_context_iteration ()
   from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#13 0x00007ffff698e157 in nsBaseAppShell::DoProcessNextNativeEvent (
    this=0x7fffec7ca350, mayWait=<value optimized out>)
---Type <return> to continue, or q <return> to quit---
    at /build/buildd/firefox-4.0.1+build1+nobinonly/build-tree/mozilla/widget/src/xpwidgets/nsBaseAppShell.cpp:173
#14 0x00007ffff698e31d in nsBaseAppShell::OnProcessNextEvent (this=0x7fffec7ca350,
    thr=0x7fffec70ec90, mayWait=0, recursionDepth=<value optimized out>)
    at /build/buildd/firefox-4.0.1+build1+nobinonly/build-tree/mozilla/widget/src/xpwidgets/nsBaseAppShell.cpp:333
#15 0x00007ffff6b19ed9 in nsThread::ProcessNextEvent (this=0x7fffec70ec90,
    mayWait=0, result=0x7fffffffd62c)
    at /build/buildd/firefox-4.0.1+build1+nobinonly/build-tree/mozilla/xpcom/threads/nsThread.cpp:597
#16 0x00007ffff6ae9ab8 in NS_ProcessNextEvent_P (thread=<value optimized out>,
    mayWait=<value optimized out>) at nsThreadUtils.cpp:250
#17 0x00007ffff6a31cec in mozilla::ipc::MessagePump::Run (this=0x7fffe6a2e6c0,
    aDelegate=0x7fffec73e9e0)
    at /build/buildd/firefox-4.0.1+build1+nobinonly/build-tree/mozilla/ipc/glue/MessagePump.cpp:110
#18 0x00007ffff6b48a43 in RunHandler (this=0x7fffec73e9e0)
    at /build/buildd/firefox-4.0.1+build1+nobinonly/build-tree/mozilla/ipc/chromium/src/base/message_loop.cc:202
#19 MessageLoop::Run (this=0x7fffec73e9e0)
    at /build/buildd/firefox-4.0.1+build1+nobinonly/build-tree/mozilla/ipc/chromium/src/base/message_loop.cc:176
#20 0x00007ffff698df45 in nsBaseAppShell::Run (this=0x7fffec7ca350)
    at /build/buildd/firefox-4.0.1+build1+nobinonly/build-tree/mozilla/widget/src/xpwidgets/nsBaseAppShell.cpp:192
#21 0x00007ffff6862f26 in nsAppStartup::Run (this=0x7fffe187a800)
    at /build/buildd/firefox-4.0.1+build1+nobinonly/build-tree/mozilla/toolkit/compo---Type <return> to continue, or q <return> to quit---
nents/startup/src/nsAppStartup.cpp:220
#22 0x00007ffff612f197 in XRE_main (argc=<value optimized out>,
    argv=<value optimized out>, aAppData=<value optimized out>)
    at /build/buildd/firefox-4.0.1+build1+nobinonly/build-tree/mozilla/toolkit/xre/nsAppRunner.cpp:3786
#23 0x00007ffff7ff3d58 in main (argc=1, argv=0x7fffffffe268)
    at /build/buildd/firefox-4.0.1+build1+nobinonly/build-tree/mozilla/browser/app/nsBrowserApp.cpp:158
(gdb)

Related links:
http://seleniumhq.org/projects/ide/
http://code.google.com/p/selenium/issues/detail?id=1616
http://code.google.com/p/selenium/issues/detail?id=1642

See original description
Luiz Armesto (luiz-armesto)
description: updated
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Where can I find a version of Selenium that's actually compatible with Firefox 4.0.1?

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

This is a fairly common crasher it seems: https://crash-stats.mozilla.com/report/list?product=Firefox&platform=linux&query_search=signature&query_type=contains&query=uGlobalMenu&reason_type=contains&date=05%2F16%2F2011%2023%3A29%3A46&range_value=1&range_unit=weeks&hang_type=any&process_type=any&do_query=1&signature=uGlobalMenu%3A%3AAboutToOpen

Changed in globalmenu-extension:
assignee: nobody → Chris Coulson (chrisccoulson)
importance: Undecided → Critical
status: New → Triaged
Changed in firefox (Ubuntu):
status: New → Triaged
importance: Undecided → High
Changed in firefox (Ubuntu Natty):
importance: Undecided → High
status: New → Triaged
milestone: none → natty-updates
assignee: nobody → Chris Coulson (chrisccoulson)
Changed in firefox (Ubuntu):
assignee: nobody → Chris Coulson (chrisccoulson)
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

The menu which causes this crash doesn't actually have a popup and hence no content. I'm confused how it even gets this signal (AboutToShow) though, as the particular menu is hidden and the crash occurs as soon as the window is opened (before you even have a chance to open a menu). Ted, do you know if the panel does anything funny here?

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

bzr commit -m "Fix LP: 783790 - don't process any signals for menus with no popups"
Committing to: /home/chr1s/src/globalmenu-extension/globalmenu-extension/
modified extensions/globalmenu/components/src/uGlobalMenu.cpp
Committed revision 160.

Changed in globalmenu-extension:
status: Triaged → Fix Committed
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

bzr commit -m "Fix LP: 783790 - don't process any signals for menus with no popups"
Committing to: /home/chr1s/src/globalmenu-extension/1.0/
modified extensions/globalmenu/install.rdf
modified extensions/globalmenu/components/src/uGlobalMenu.cpp
Committed revision 153.

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

This has caused 142 crash reports in the last 1 week alone

Chris Coulson (chrisccoulson)
description: updated
Chris Coulson (chrisccoulson)
Changed in firefox (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Luiz Armesto (luiz-armesto) wrote :

>> Where can I find a version of Selenium that's actually compatible with Firefox 4.0.1?

Hi Chris. You can get a snapshot version compatible with Firefox 4 from http://xserve.openqa.org:8085/browse/IDE-IDE/latest

Thank you.

Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Accepted firefox into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in firefox (Ubuntu Natty):
status: Triaged → Fix Committed
tags: added: verification-needed
Revision history for this message
Luiz Armesto (luiz-armesto) wrote :

Hi Martin. I tested and there is no more crashes. It's working as expected.

Thank you.

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

Thanks for testing Luiz. Marking as verification-done

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (4.8 KiB)

This bug was fixed in the package firefox - 5.0~b2+build1+nobinonly-0ubuntu1

---------------
firefox (5.0~b2+build1+nobinonly-0ubuntu1) oneiric; urgency=low

  * New upstream release from the beta channel (FIREFOX_5_0b2_BUILD1)
    - Fixes LP: #765970

  * Switch to mozilla-beta
    - update debian/mozclient/firefox.conf
  * Drop support for building with an external xulrunner
    - update debian/apport/firefox.in
    - update debian/firefox.install.in
    - update debian/firefox.lintian-overrides.in
    - update debian/firefox.sh.in
    - update debian/mozconfig.in
    - update debian/rules
  * Ditch all the version-number based branding selection. Do this all
    purely on the channel name now
    - remove debian/firefox-beta.desktop.in
    - remove debian/firefox-nightly.desktop.in
    - remove debian/firefox-unofficial.desktop.in
    - rename debian/firefox-final.desktop.in => debian/firefox.desktop.in
    - update debian/firefox.desktop.in
    - update debian/rules
    - update debian/firefox.sh.in
  * Drop the DEB_ENABLE_IPC option, now that IPC is mandatory
    - update debian/rules
    - update debian/apport/firefox.in
    - update debian/firefox.install.in
    - update debian/mozconfig.in
  * Build language packs directly from the firefox source
    + Fixes LP: #294187 - Firefox Locales should install locale specific
      search plugins
    + Rip out the bits to create a en-US.xpi
      - update debian/rules
      - remove debian/translation-support/install.rdf.in
    + Include compare-locales FIREFOX_5_0b1_BUILD1 from
      http://hg.mozilla.org/build/compare-locales. It's needed for merging
      en-US strings with incomplete locales
    + Pull l10n data in to tarball from bzr
      - update debian/mozclient/firefox.conf
    + Configure build for creating language packs by configuring with
      "--with-l10n-base="
      - update debian/mozconfig.in
    + Store the list of locales to ship, and provide a way of automatically
      generating that list and the control file entries from the upstream
      source. Also provide a way to blacklist languages. We map languages
      to package names using langpack-o-matic (and also get descriptions
      from there too)
      - update debian/rules
      - add debian/locales-supported
      - add debian/control.langpacks
      - update debian/control
      - add debian/locale-blacklist
      - add debian/refresh-supported-locales.pl
    + Add common-build-indep hook to build the translation xpi's
      - update debian/rules
    + Add common-binary-post-install-indep to install the xpi's and
      searchplugins in to the correct debian packages
      - update debian/rules
      - add debian/get-xpi-id.py
    + When rebuilding debian/control in the clean target, fail the build
      if the control file was out-of-date. This ensures that we don't
      accidentally drop language packs, and forces me to maintain an
      up-to-date control file in bzr
      - update debian/rules
    + Apply vendor patches to localized searchplugins too
      - update debian/patches/ubuntu-codes-amazon.patch
      - add debian/patches/ubuntu-codes-baidu.patch
      - update debian/patches/ubuntu-codes-google.p...

Read more...

Changed in firefox (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firefox - 4.0.1+build1+nobinonly-0ubuntu0.11.04.3

---------------
firefox (4.0.1+build1+nobinonly-0ubuntu0.11.04.3) natty-proposed; urgency=low

  * Update globalmenu-extension to 1.0.5:
  * Fix LP: #783790 - Firefox 4 crashes when opening Selenium IDE window.
    Ignore signals for menus without popups
  * Fix LP: #783856 - Firefox 4.0.1 Crash Report
    [@ uGlobalMenuBar::~uGlobalMenuBar ]. Don't bail out of building a menu
    when encountering a non-XUL element. Also toughen up destructors to not
    crash if the menuitem never initialized properly
  * Fix LP: #783997 - Firefox 4.0.1 Crash Report
    [@ uGlobalMenuBar::ShouldParentStayVisible ]. Don't crash if the window
    gets destroyed before the panel responds to RegisterWindow
 -- Chris Coulson <email address hidden> Tue, 17 May 2011 18:28:28 +0100

Changed in firefox (Ubuntu Natty):
status: Fix Committed → Fix Released
Chris Coulson (chrisccoulson)
Changed in globalmenu-extension:
status: Fix Committed → Fix Released
Ubuntu Foundations Team Bug Bot (crichton)
tags: added: testcase
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.