In subscription.h Limit timeout is defined float, I believe it should be uint64_t
Bug #1475888 reported by
gokhanettin
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Grail |
Fix Released
|
Medium
|
Stephen M. Webb |
Bug Description
Browsing the code online, I noticed
in subscription.h line 35 timeout is of type float.
struct Limit {
float timeout;
float threshold;
};
In subscription.cpp line 107 value is cast to uint64_t and drag_timeout is set as uint64_t
case UGSubscriptionP
uint64_t timeout = *reinterpret_
if (timeout < 0)
return UGStatusErrorIn
drag_.timeout = timeout;
return UGStatusSuccess;
}
Related branches
lp://qastaging/~bregma/grail/lp-1475888
- PS Jenkins bot (community): Approve (continuous-integration)
- Brandon Schaefer (community): Approve
-
Diff: 146 lines (+16/-27)5 files modifiedm4/xorg-gtest.m4 (+7/-6)
src/subscription.cpp (+4/-16)
src/subscription.h (+2/-2)
test/gtest/Makefile.am (+2/-2)
test/integration/x11/timeout.cpp (+1/-1)
Changed in grail: | |
status: | New → Triaged |
importance: | Undecided → Medium |
assignee: | nobody → Stephen M. Webb (bregma) |
milestone: | none → 3.1.1 |
Changed in grail: | |
status: | Triaged → In Progress |
Changed in grail: | |
status: | In Progress → Fix Committed |
Changed in grail: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.