Stack with subnet update failed due the cidr overlaps with another

Bug #1553088 reported by huangtianhua
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Heat
In Progress
Medium
huangtianhua

Bug Description

1. create a stack with neutron subnet:
*************************************
heat_template_version: 2014-10-16
resources:
  subnet:
    type: OS::Neutron::Subnet
    properties:
      network_id: 3447dd80-14ef-4059-8ea6-35f4fd60ba26
      cidr: 102.0.0.0/24
    deletion_policy: Retain
*************************************

2. update the subnet with another cidr: 112.0.0.0/24, stack update successful

3. to update the subnet back to old cidr: 102.0.0.0/24, stack update failed, due the cidr overlaps with other subnet in network.

In step2, we replace the subnet with the new cidr, but the old subnet retain due the deletion_policy.
So we need to consider this user case to make sure the update success.

Changed in heat:
assignee: nobody → huangtianhua (huangtianhua)
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/290311

Changed in heat:
status: New → In Progress
Changed in heat:
milestone: none → mitaka-rc1
Revision history for this message
Anant Patil (ananta) wrote :

Is it ok for a user to have his/her delete-retained resource be deleted because it got update-replaced? I am ok with heat failing gracefully and complaining properly about the error instead of deleting something user never wanted?

Revision history for this message
Jay Dobies (jdob) wrote :

I was thinking the same thing as Anant. I don't like the idea of implicitly changing that flag without the user's input. I'd be curious to see the behavior if deletion_policy was changed during the first update and if that's the flow the user should take.

Changed in heat:
milestone: mitaka-rc1 → newton-1
Rabi Mishra (rabi)
Changed in heat:
milestone: newton-1 → newton-2
Thomas Herve (therve)
Changed in heat:
milestone: newton-2 → newton-3
Thomas Herve (therve)
Changed in heat:
milestone: newton-3 → next
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on heat (master)

Change abandoned by Rico Lin (<email address hidden>) on branch: master
Review: https://review.openstack.org/290311
Reason: Hi, this patch stays untouched for few months, would like to abandon for now. Feel free to restore it if you still working on this. Thank you!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.